Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-16 Thread Etienne Chauchot
Hi, OK. I thought that not changing the artifact did not require a new RC as the release doc says that "some changes" do not require RC invalidation (it is my first release :) ). Thanks. I'll cancel this release vote and start a RC2 vote. Regarding the empty tool directory, as mentioned

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Chesnay Schepler
Martijn is correct in that if the source release got changed we need to vet everything again. If anything else had been changed instead there'd be a bit of leeway but the source release itself is the most important bit of a release and we just can't allow changes to that after the fact and

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Martijn Visser
Hi Etienne, > I fixed the source release [1] as requested, it no more contains > tools/release/shared directory. I don't think that is the correct way: my understanding is that this invalidates basically all the votes, because now the checked artifact has changed. It was requested to file a

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-15 Thread Etienne Chauchot
Hi, Considering that the code and artifact have note changed since last vote (only source release and tag have changed) and considering that there were already 3 binding votes for this RC1, I'll do this on a lazy consensus. I'll release if no one objects until tomorrow as it will be 72h

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-13 Thread Etienne Chauchot
Hi all, I fixed the source release [1] as requested, it no more contains tools/release/shared directory. I found out why it contained that directory, it was because parent_pom branch was referring to an incorrect sub-module mount point for release_utils branch (cf FLINK-34364 [2]). Here is

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-05 Thread Etienne Chauchot
Hi, I just got back from vacations. I'll close the vote thread and proceed to the release later this week. Here is the ticket: https://issues.apache.org/jira/browse/FLINK-34364 Best Etienne Le 04/02/2024 à 05:06, Qingsheng Ren a écrit : +1 (binding) - Verified checksum and signature -

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-03 Thread Qingsheng Ren
+1 (binding) - Verified checksum and signature - Verified pom content - Built flink-connector-kafka from source with the parent pom in staging Best, Qingsheng On Thu, Feb 1, 2024 at 11:19 PM Chesnay Schepler wrote: > - checked source/maven pom contents > > Please file a ticket to exclude

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-02-01 Thread Chesnay Schepler
- checked source/maven pom contents Please file a ticket to exclude tools/release from the source release. +1 (binding) On 29/01/2024 15:59, Maximilian Michels wrote: - Inspected the source for licenses and corresponding headers - Checksums and signature OK +1 (binding) On Tue, Jan 23, 2024

Re: [VOTE] Release flink-connector-parent, release candidate #1

2024-01-29 Thread Maximilian Michels
- Inspected the source for licenses and corresponding headers - Checksums and signature OK +1 (binding) On Tue, Jan 23, 2024 at 4:08 PM Etienne Chauchot wrote: > > Hi everyone, > > Please review and vote on the release candidate #1 for the version > 1.1.0, as follows: > > [ ] +1, Approve the

[VOTE] Release flink-connector-parent, release candidate #1

2024-01-23 Thread Etienne Chauchot
Hi everyone, Please review and vote on the release candidate #1 for the version 1.1.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes