Jark Wu created FLINK-15441:
-------------------------------

             Summary: Refactor StreamExecWindowJoin to extends 
CommonPhysicalJoin
                 Key: FLINK-15441
                 URL: https://issues.apache.org/jira/browse/FLINK-15441
             Project: Flink
          Issue Type: Improvement
          Components: Table SQL / Planner
            Reporter: Jark Wu


Currently, {{StreamExecWindowJoin}} put join keys in the {{remainCondition}}, 
this will generate redundant condition for join keys, and results in [this code 
branch 
|https://github.com/apache/flink/blob/master/flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowJoinUtil.scala#L128]
 is never reached. 

I better desgin is have a new {{joinCondition}} which removes the window bounds 
condition, and generate condition for non-equal conditions in 
{{joinCondition}}, and make {{StreamExecWindowJoin}} extends 
{{CommonPhysicalJoin}} . We should also take filter null join keys into 
account. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to