答复: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-26 Thread shijinkui
duty. -邮件原件- 发件人: Maximilian Michels [mailto:m...@apache.org] 发送时间: 2016年9月26日 16:33 收件人: dev@flink.apache.org 主题: Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test Hello Jinkui Shi, Due to the nature of most of the Yarn tests, we need them to be in a separate module. More

Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-26 Thread Maximilian Michels
Hello Jinkui Shi, Due to the nature of most of the Yarn tests, we need them to be in a separate module. More concretely, these tests have a dependency on 'flink-dist' because they need to deploy the Flink fat jar to the Yarn tests cluster. The fat jar also contains the 'flink-yarn' code. Thus,

Re: 答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-22 Thread Stephan Ewen
"flink-test-utils" contains, as the name says, utils for testing. Intended to be used by users in writing their own tests. "flink-tests" contains cross module tests, no user should ever need to have a dependency on that. They are different because users explicitly asked for test utils to be

答复: [discuss] merge module flink-yarn and flink-yarn-test

2016-09-21 Thread shijinkui
Hi, Stephan Thanks for your reply. In my mind, Maven-shade-plugin and sbt-assembly both default exclude test code for the fat jar. In fact, unit tests are use to test the main code, ensure our code logic fit our expect . This is general convention. I think. Flink has be a top apache