Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Sergey Nuyanzin
Thanks everyone for the feedback This RC is cancelled and a new one will be created On Thu, Feb 1, 2024 at 2:42 AM Leonard Xu wrote: > Thanks Sergey for driving this! > > -1(binding) as we discussed on the web PR[1], looking forward next RC. > > Best, > Leonard > [1]

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Leonard Xu
Thanks Sergey for driving this! -1(binding) as we discussed on the web PR[1], looking forward next RC. Best, Leonard [1] https://github.com/apache/flink-web/pull/707#discussion_r1471090061 > 2024年1月30日 上午8:17,Sergey Nuyanzin 写道: > > Hi everyone, > Please review and vote on the release

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Sergey Nuyanzin
d JDBC java 17 support (FLINK-33787) be included in this > release? > * The Flink version in the pom is 1.17, but we are saying we support > Flink 1.16. > > > Kind regards, David. > > From: Sergey Nuyanzin > Date: Tuesday, 30 January 2024 at 00:18 > To: dev@flink.apache.org >

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread David Radley
flink-connector-jdbc, release candidate #2 Hi everyone, Please review and vote on the release candidate #2 for the version 3.1.2, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Hang Ruan
+1 (non-binding) - Validated checksum hash - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven and jdk11 - Verified web PR - Check that the jar is built by jdk8 Best, Hang Jiabao Sun 于2024年1月30日周二 10:52写道: > +1(non-binding) > > - Release

RE: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Jiabao Sun
+1(non-binding) - Release notes look good - Tag is present in Github - Validated checksum hash - Verified signature - Verified web PR and left minor comments Best, Jiabao On 2024/01/30 00:17:54 Sergey Nuyanzin wrote: > Hi everyone, > Please review and vote on the release candidate #2 for the

[VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Sergey Nuyanzin
Hi everyone, Please review and vote on the release candidate #2 for the version 3.1.2, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x. The complete staging area is

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-21 Thread Martijn Visser
Hi all, I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: * Sergey Nuyanzin (non-binding) * Dawid (binding) * Martijn (binding) * Danny (binding) There are no disapproving votes. Thanks everyone! Best regards, Martijn

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-20 Thread Danny Cranmer
Hello, +1 (binding) - Release notes look good - Verified signatures and hashes - Verified there are no binaries in the source archive - NOTICE/Licenses look good - Built source - Tag exists in Github - Contents of Maven repo look good - Reviewed web PR Thanks, On Tue, Dec 20, 2022 at 12:04 PM

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-20 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PR On Mon, Dec 19, 2022 at 3:53 PM Dawid Wysakowicz wrote: > +1 (binding) > >- verified signatures and checksums >

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-19 Thread Dawid Wysakowicz
+1 (binding) * verified signatures and checksums * built from sources * the PR looks good * the artifacts to be published look fine * checked files diff to the 1.16.0 release tag Best, Dawid On 19/12/2022 12:17, Sergey Nuyanzin wrote: +1 (non-binding) - Validated hashes and signature -

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-19 Thread Sergey Nuyanzin
+1 (non-binding) - Validated hashes and signature - Verified that no binaries exist in the source archive - Build from sources with Maven - Verified licenses one nitpick: it seems a link to the tag is broken (number 5) I guess it should be this one

[VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-14 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #2 for the version 3.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *