Re: Design Question in Expression API

2015-02-03 Thread Max Michels
If we want to have a tight integration with our existing API we have to hide the results of the expressions behind a wrapper. This enables us to change the internal implementation at any time and support future Flink API changes and features. +1 for not directly exposing the results as a row DataS

Re: Design Question in Expression API

2015-02-03 Thread Fabian Hueske
I am also +1 for hiding the internals. Having conversion functions from and to DataSet sounds like the way to go for me. 2015-01-31 11:04 GMT+01:00 Aljoscha Krettek : > Yes, that's exactly my reasoning for wanting to hide it. > > On Sat, Jan 31, 2015 at 10:32 AM, Stephan Ewen wrote: > > My firs

Re: Design Question in Expression API

2015-01-31 Thread Aljoscha Krettek
Yes, that's exactly my reasoning for wanting to hide it. On Sat, Jan 31, 2015 at 10:32 AM, Stephan Ewen wrote: > My first Intuition is to not expose the row data type. If we add columnar > executing later, there may never be a Row data type during runtime (cp > paper on hyper runtime engine). > >

Re: Design Question in Expression API

2015-01-31 Thread Stephan Ewen
My first Intuition is to not expose the row data type. If we add columnar executing later, there may never be a Row data type during runtime (cp paper on hyper runtime engine). For these declarative operations, I think it is a big advantage to keep the underpinnings strictly separate so we can cha

Re: Design Question in Expression API

2015-01-30 Thread Aljoscha Krettek
Yes, that's what I'm afraid about. I would also like to have the flexibility to change the underlying implementation in the future, if we want to. And no, hiding the implementation would actually make things easier, implementation wise. On Fri, Jan 30, 2015 at 7:08 PM, Robert Metzger wrote: > Hi,

Re: Design Question in Expression API

2015-01-30 Thread Robert Metzger
Hi, Am I right that you basically fear that if you are allowing users to "manually" modify DataSet's that you're loosing control of the types etc.? I think that integrating the expression API into the existing API is nicer, because it gives users more flexibility. It should also lead to a lower o

Design Question in Expression API

2015-01-29 Thread Aljoscha Krettek
Hi, I have to decide whether to expose the implementation or hide it from the user and would like to hear some opinions about that. The expression operations operate on DataSet[Row], where Row is basically a wrapper for an array of elements of different types. The expression API system keeps track