Matthias,
Won't this be a compile-time error as long as the user is parameterizing
the return type since .fromElements(OUT...) returns DataStreamSource
and will bind to the nearest common superclass? The new
.fromElements(Class, OUT...) does give the user the choice of common
superclass.
Greg
I guess, removing .fromElements(Object..) would fix the problem. Not
sure so, if we can remove the method due to API stability...
I don't see any other good solution (even if the current implementation
gives a nice behavior by accident...):
If you have a complex class hierarchy, it would be
You’re completely right Mathias. The compiler shouldn’t allow something
like env.fromElements(SubClass.class, new ParentClass()) if it weren’t for
the overloaded method. Thus, the test case is somewhat bogus.
I’m actually wondering why the initial problem
Hi Till,
but StreamExecutionEnvironmentTest.fromElementWithBaseTypeTest2 does not
test was you describe -- even if it is intended to test it.
It would test your describe scenario, if fromElements(Class, X...)
would be called, But this call is not possible because X is defined a
type Subclass and
Even if the fix works, I still have two issues in my Eclipse build...
In
flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
Eclipse cannot infer the integer type. It could be fixed if you make the
type explicit (as this is only a test, it might be nice
Cool, thank you for working on this!
On Mon, Apr 25, 2016 at 1:37 PM, Matthias J. Sax wrote:
> I can confirm that the SO answer works.
>
> I will add a note to the Eclipse setup guide at the web site.
>
> -Matthias
>
>
> On 04/25/2016 11:33 AM, Robert Metzger wrote:
> > It
I can confirm that the SO answer works.
I will add a note to the Eclipse setup guide at the web site.
-Matthias
On 04/25/2016 11:33 AM, Robert Metzger wrote:
> It seems that the user resolved the issue on SO, right?
>
> On Mon, Apr 25, 2016 at 11:31 AM, Ufuk Celebi wrote:
>
It seems that the user resolved the issue on SO, right?
On Mon, Apr 25, 2016 at 11:31 AM, Ufuk Celebi wrote:
> On Mon, Apr 25, 2016 at 12:14 AM, Matthias J. Sax
> wrote:
> > What do you think about this?
>
> Hey Matthias!
>
> Thanks for bringing this up.
>
>
On Mon, Apr 25, 2016 at 12:14 AM, Matthias J. Sax wrote:
> What do you think about this?
Hey Matthias!
Thanks for bringing this up.
I think it is very desirable to keep support for Eclipse. It's quite a
high barrier for new contributors to enforce a specific IDE (although