Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-21 Thread Chesnay Schepler
There's a separate discussion altogether. On 21/07/2023 02:49, Mason Chen wrote: Hi all, I agree getScopeVariables is in line with the existing terminology but I’ve seen that the existing terminology is a bit confusing with regards to how users end up querying these metrics and building

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-20 Thread Mason Chen
Hi all, I agree getScopeVariables is in line with the existing terminology but I’ve seen that the existing terminology is a bit confusing with regards to how users end up querying these metrics and building alerts/dashboards. I often get the question how do I add a tag or label to my Flink

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-20 Thread Chesnay Schepler
environment variables is a very different though though, that'd just confuse users. It's also not a term we've used in the documentation. getScopeVariables would I guess be most in line with existing terminology. On 19/07/2023 18:10, Matthias Pohl wrote: We don't have a well-defined process

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-19 Thread Matthias Pohl
> > We don't have a well-defined process for breaking behavioral changes. We > could consider adding a new method with a different name. Introducing a new API to make the behavioral change visible was also the suggestion in the deprecation ML thread [1]. getEnvironmentVariables (or even

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-18 Thread Jing Ge
+1 On Tue, Jul 18, 2023 at 12:24 PM Xintong Song wrote: > +1 > > Best, > > Xintong > > > > On Tue, Jul 18, 2023 at 5:02 PM Chesnay Schepler > wrote: > > > The FLIP number was changed to 342. > > > > On 18/07/2023 10:56, Chesnay Schepler wrote: > > > MetricGroup#getAllVariables returns all

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-18 Thread Xintong Song
+1 Best, Xintong On Tue, Jul 18, 2023 at 5:02 PM Chesnay Schepler wrote: > The FLIP number was changed to 342. > > On 18/07/2023 10:56, Chesnay Schepler wrote: > > MetricGroup#getAllVariables returns all variables associated with the > > metric, for example: > > > > | = abcde| > > | = ||0|

Re: FLIP-342: Remove brackets around keys returned by MetricGroup#getAllVariables

2023-07-18 Thread Chesnay Schepler
The FLIP number was changed to 342. On 18/07/2023 10:56, Chesnay Schepler wrote: MetricGroup#getAllVariables returns all variables associated with the metric, for example: | = abcde| | = ||0| The keys are surrounded by brackets for no particular reason. In virtually every use-case for this