Re: Fwd: Discussion: Storm Comparability Layer

2015-06-04 Thread Márton Balassi
Yes, this is indeed a big change, but it was openly discussed multiple times here on the mailing list and in a number of PRs. I am pretty sure that we do not want to break the source interface any more, but there is still some open discussion on it. Let us keep an eye on PR 742 where it is

Re: Fwd: Discussion: Storm Comparability Layer

2015-06-04 Thread Aljoscha Krettek
The back-and-forth on the Source interface was unfortunate, yes. In general, I think, that we should not doctor around on other peoples's pull requests in semi secrecy. Some small cosmetic fixes or rewordings of the commit message are OK. But if the PR needs rework then this should be voiced in

Re: Fwd: Discussion: Storm Comparability Layer

2015-06-03 Thread Márton Balassi
Thanks for the updates, Matthias. Both of your questions get an other context, because we have decided to go back to the run()/cancel() type of source interface - but with a slightly changed signature to enable transactional operator state checkpointing. You can check out the new source interface

Re: Fwd: Discussion: Storm Comparability Layer

2015-06-03 Thread Matthias J. Sax
Thanks for the info. I am just a little bit disappointed. The whole rewrite to the new interface was unnecessary... We need to revert everything again... I can also stop working on the new StormSpoutWrapper and StormSpoutCollector implementation in this case... Let's see how it goes. But from my