Re: Limitations on grouped ReduceFunction

2016-02-03 Thread Stephan Ewen
For now, I think it is worth documenting and leaving it as it is. A while back we thought about adding a Static Code Analysis rule to find such cases and create a warning. For Reduce, that is quite straightforward, for GrouReduce quite tricky... Am 02.02.2016 21:55 schrieb "Greg Hogan"

Limitations on grouped ReduceFunction

2016-02-02 Thread Greg Hogan
If a user modifies keyed fields of a grouped reduce during a combine then the reduce will receive incorrect groupings. For example, a useless modification to word count: public WC reduce(WC in1, WC in2) { return new WC(in1.word + " " + in2.word, in1.count + in2.count); } I don't see an