Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-10-12 Thread Junrui Lee
warnings if the content is such that the user would need to >> manually fix up the file. >> If there are minimal user fixups, we should consider automatically >> migrating the config file to the new format, >> Kind regards, David. >> >> >> >

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-10-08 Thread Junrui Lee
Kind regards, David. > > > > > From: Chesnay Schepler > Date: Tuesday, 3 October 2023 at 11:17 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [Discuss] FLIP-366: Support standard YAML for > FLINK configuration > It is a unfortunate that we'll need a separate conf

RE: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-10-03 Thread David Radley
:17 To: dev@flink.apache.org Subject: [EXTERNAL] Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration It is a unfortunate that we'll need a separate config file but the FLIP does a good job justifying it. Personally I'd just name it "config.yaml"; I never quite unde

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-10-03 Thread Chesnay Schepler
It is a unfortunate that we'll need a separate config file but the FLIP does a good job justifying it. Personally I'd just name it "config.yaml"; I never quite understood why there was a flink prefix to begin with, and the current proposal ("flink-configuration.yaml") seems unnecessarily

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-22 Thread Jane Chan
Hi, Junrui, Sorry for the late reply. The update looks good to me and thanks for your effort! Best, Jane On Fri, Sep 22, 2023 at 2:25 PM Yuxin Tan wrote: > Hi, Junrui > > +1 for the proposal. > Thanks for your effort. > > Best, > Yuxin > > > Samrat Deb 于2023年9月22日周五 13:23写道: > > > Hello

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-22 Thread Yuxin Tan
Hi, Junrui +1 for the proposal. Thanks for your effort. Best, Yuxin Samrat Deb 于2023年9月22日周五 13:23写道: > Hello Junrui, > > +1 for the proposal. > > > Bests, > Samrat > > On Fri, Sep 22, 2023 at 10:18 AM Shammon FY wrote: > > > +1 for the proposal, thanks for driving. > > > > Bet, > > Shammon

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread Samrat Deb
Hello Junrui, +1 for the proposal. Bests, Samrat On Fri, Sep 22, 2023 at 10:18 AM Shammon FY wrote: > +1 for the proposal, thanks for driving. > > Bet, > Shammon FY > > On Fri, Sep 22, 2023 at 12:41 PM Yangze Guo wrote: > > > Thanks for driving this, +1 for the proposal. > > > > Best, > >

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread Shammon FY
+1 for the proposal, thanks for driving. Bet, Shammon FY On Fri, Sep 22, 2023 at 12:41 PM Yangze Guo wrote: > Thanks for driving this, +1 for the proposal. > > Best, > Yangze Guo > > > On Fri, Sep 22, 2023 at 11:59 AM Lijie Wang > wrote: > > > > Hi Junrui, > > > > +1 for this proposal, thanks

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread Yangze Guo
Thanks for driving this, +1 for the proposal. Best, Yangze Guo On Fri, Sep 22, 2023 at 11:59 AM Lijie Wang wrote: > > Hi Junrui, > > +1 for this proposal, thanks for driving. > > Best, > Lijie > > ConradJam 于2023年9月22日周五 10:07写道: > > > +1 Support for standard YAML format facilitates

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread Lijie Wang
Hi Junrui, +1 for this proposal, thanks for driving. Best, Lijie ConradJam 于2023年9月22日周五 10:07写道: > +1 Support for standard YAML format facilitates specification > > Jing Ge 于2023年9月22日周五 02:23写道: > > > Hi Junrui, > > > > +1 for following the standard. Thanks for your effort! > > > > Best

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread ConradJam
+1 Support for standard YAML format facilitates specification Jing Ge 于2023年9月22日周五 02:23写道: > Hi Junrui, > > +1 for following the standard. Thanks for your effort! > > Best regards, > Jing > > On Thu, Sep 21, 2023 at 5:09 AM Junrui Lee wrote: > > > Hi Jane, > > > > Thank you for your valuable

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-21 Thread Jing Ge
Hi Junrui, +1 for following the standard. Thanks for your effort! Best regards, Jing On Thu, Sep 21, 2023 at 5:09 AM Junrui Lee wrote: > Hi Jane, > > Thank you for your valuable feedback and suggestions. > I agree with your point about differentiating between "flink-config.yaml" > and

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-20 Thread Junrui Lee
Hi Jane, Thank you for your valuable feedback and suggestions. I agree with your point about differentiating between "flink-config.yaml" and "flink-conf.yaml" to determine the standard syntax at a glance. While I understand your suggestion of using "flink-conf-default.yaml" to represent the

Re: [Discuss] FLIP-366: Support standard YAML for FLINK configuration

2023-09-20 Thread Jane Chan
Hi Junrui, Thanks for driving this FLIP. +1 for adoption of the standard YAML syntax. I just have one minor suggestion. It's a little bit challenging to differentiate between `flink-config.yaml` and `flink-conf.yaml` to determine which one uses the standard syntax at a glance. How about using