Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-27 Thread Pēteris Kļaviņš
IMHO it would be a pity if we lost the Git history of changes made to the Blink repository since the time that it was forked from Flink. If the Blink repository is a true fork, i.e., branch at a certain time/commit id, from the Flink repository, then there is no problem. The entire Blink

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-24 Thread jincheng sun
Thanks Stephan, The entire plan makes sense to me. Regarding the branch name, how about using "blink-flink-1.5" wich meant that the branche is based on flink-1.5. If the name is "blink-1.5", some users will think that this is the version number of the internal Blink of alibaba, and will not

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-24 Thread Bowen Li
Exciting to see this happening! Wrt doc, have we done a diff which can show us how much differences are between Flink's and Blink's documentation (flink/docs)? For example, how many pages and how much percentage of each page is different? How many new pages (for new features) does Blink have?If

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-24 Thread Kurt Young
Sure, i will do the rebase before pushing the branch. Timo Walther 于2019年1月24日 周四18:20写道: > Regarding the content of a `blink-1.5` branch, is it possible to rebase > the big Blink commit on top of the current master or the last Flink > release? > > I don't mean a full rebase here, but just

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-24 Thread Timo Walther
Regarding the content of a `blink-1.5` branch, is it possible to rebase the big Blink commit on top of the current master or the last Flink release? I don't mean a full rebase here, but just forking the branch from current Flink, and putting the Blink content into the repository, and commit

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Becket Qin
Thanks Stephan, The plan makes sense to me. Regarding the docs, it seems better to have a separate versioned website because there are a lot of changes spread over the places. We can add the banner to remind users that they are looking at the blink docs, which is temporary and will eventually be

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Shaoxuan Wang
Thanks Stephan, The entire plan looks good to me. WRT the "Docs for Flink", a subsection should be good enough if we just introduce the outlines of what blink has changed. However, we have made detailed introductions to blink based on the framework of current release document of Flink (those

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Stephan Ewen
Nice to see this lively discussion. *--- Branch Versus Repository ---* Looks like this is converging towards pushing a branch. How about naming the branch simply "blink-1.5" ? That would be in line with the 1.5 version branch of Flink, which is simply called "release-1.5" ? *--- SGA --- * The

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Becket Qin
Really excited to see Blink joining the Flink community! My two cents regarding repo v.s. branch, I am +1 for a branch in Flink. Among many things, what's most important at this point is probably to make Blink code available to the developers so people can discuss the merge strategy. Creating a

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Chesnay Schepler
From the ASF side Jar files do notrequire a vote/release process, this is at the discretion of the PMC. However, I have my doubts whether at this time we could even create a source release of Blink given that we'd have to vet the code-base first. Even without source release we could still

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Timo Walther
As far as I know it, we will not provide any binaries but only the source code. JAR files on Apache servers would need an official voting/release process. Interested users can build Blink themselves using `mvn clean package`. @Stephan: Please correct me if I'm wrong. Regards, Timo Am

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Kurt Young
Hi Timo, What about the jar files, will blink's jar be uploaded to apache repository? If not, i think it will be very inconvenient for users who wants to try blink and view the documents if they need some help from doc. Best, Kurt On Wed, Jan 23, 2019 at 6:09 PM Timo Walther wrote: > Hi

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Timo Walther
Hi Kurt, I would not make the Blink's documentation visible to users or search engines via a website. Otherwise this would communicate that Blink is an official release. I would suggest to put the Blink docs into `/docs` and people can build it with `./docs/build.sh -pi` if there are

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-23 Thread Kurt Young
Thanks @Stephan for this exciting announcement! >From my point of view, i would prefer to use branch. It makes the message "Blink is pat of Flink" more straightforward and clear. Except for the location of blink codes, there are some other questions like what version should should use, and where

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread zhijiang
Glad to see this announcement, I already heard of many users asking the time of Blink open source in China recently, and thanks Stephan for making this happen. All the enhancements or features in Blink would be eventually contirbuted/merged into Flink in more fine-grained way finally. Before

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Hequn Cheng
Hi all, @Stephan Thanks a lot for driving these efforts. I think a lot of people is already waiting for this. +1 for opening the blink source code. Both a separate repository or a special branch is ok for me. Hopefully, this will not last too long. Best, Hequn On Tue, Jan 22, 2019 at 11:35 PM

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Jark Wu
Great news! Looking forward to the new wave of developments. If Blink needs to be continuously updated, fix bugs, release versions, maybe a separate repository is a better idea. Best, Jark On Tue, 22 Jan 2019 at 18:29, Dominik Wosiński wrote: > Hey! > I also think that creating the separate

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Dominik Wosiński
Hey! I also think that creating the separate branch for Blink in Flink repo is a better idea than creating the fork as IMHO it will allow merging changes more easily. Best Regards, Dom. wt., 22 sty 2019 o 10:09 Ufuk Celebi napisał(a): > Hey Stephan and others, > > thanks for the summary. I'm

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Ufuk Celebi
Hey Stephan and others, thanks for the summary. I'm very excited about the outlined improvements. :-) Separate branch vs. fork: I'm fine with either of the suggestions. Depending on the expected strategy for merging the changes, expected number of additional changes, etc., either one or the

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread jincheng sun
Thanks Stephan! This is a very exciting news for the flink community. I recommend creating a branch for blink in the Flink repository. Just like feature development, the blink branch is a branch with many enhancements, and the enhanced functionality is continuously merged to the flink master.

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Timo Walther
Thanks for driving these efforts, Stephan! Great news that the Blink code base will be available for everyone soon. I already got access to it and the added functionality and improved architecture is impressive. There will be nice additions to Flink. I guess the Blink code base will be

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Kurt Young
Hi Driesprong, Glad to hear that you're interested with blink's codes. Actually, blink only has one branch by itself, so either a separated repo or a flink's branch works for blink's code share. Best, Kurt On Tue, Jan 22, 2019 at 2:30 PM Driesprong, Fokko wrote: > Great news Stephan! > > Why

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-21 Thread Driesprong, Fokko
Great news Stephan! Why not make the code available by having a fork of Flink on Alibaba's Github account. This will allow us to do easy diff's in the Github UI and create PR's of cherry-picked commits if needed. I can imagine that the Blink codebase has a lot of branches by itself, so just

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-21 Thread Shaoxuan Wang
big +1 to contribute Blink codebase directly into the Apache Flink project. Looking forward to the new journey. Regards, Shaoxuan On Tue, Jan 22, 2019 at 3:52 AM Xiaowei Jiang wrote: > Thanks Stephan! We are hoping to make the process as non-disruptive as > possible to the Flink community.

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-21 Thread Xiaowei Jiang
Thanks Stephan! We are hoping to make the process as non-disruptive as possible to the Flink community. Making the Blink codebase public is the first step that hopefully facilitates further discussions. Xiaowei On Monday, January 21, 2019, 11:46:28 AM PST, Stephan Ewen wrote: Dear