Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-09 Thread liu ron
Hi, Mang Thanks for your update, the FLIP looks good to me now. Best, Ron Mang Zhang 于2023年6月9日周五 12:08写道: > Hi Ron, > Thanks for your reply! > After our offline discussion, at present, there may be many of flink jobs > using non-atomic CTAS functions, especially Stream jobs, > If we only

Re: Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-07 Thread Jingsong Li
Thanks Mang for updating! Looks good to me! Best, Jingsong On Wed, Jun 7, 2023 at 2:31 PM Mang Zhang wrote: > > Hi Jingsong, > > >I have some doubts about the `TwoPhaseCatalogTable`. Generally, our > >Flink design places execution in the TableFactory or directly in the > >Catalog, so

Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-05-11 Thread Jingsong Li
Hi Mang, Thanks for starting this FLIP. I have some doubts about the `TwoPhaseCatalogTable`. Generally, our Flink design places execution in the TableFactory or directly in the Catalog, so introducing an executable table makes me feel a bit strange. (Spark is this style, but Flink may not be)

Re:Re: Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-05-10 Thread Mang Zhang
Hi Jing, Currently, we cannot determine in the planner whether the source is bounded or unbounded. So when we design the API, we use the execution model to help determine if atomicity can be supported. Thank you very much for your reply! -- Best regards, Mang Zhang At 2023-04-28

Re: Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-04-28 Thread Jing Ge
Hi Mang, Boundedness and execution modes are two orthogonal concepts. Since atomic CTAS will be only supported for bounded data, which means it does not depend on the execution modes. I was wondering if it is possible to only provide (or call) twoPhaseCreateTable for bounded data (in both

Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-04-24 Thread Jing Ge
Hi Mang, Thanks for clarifying it. I am trying to understand your thoughts. Do you actually mean the boundedness[1] instead of the execution modes[2]? I.e. the atomic CTAS will be only supported for bounded data. Best regards, Jing [1]