Re:Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-08 Thread Wencong Liu
Thanks for the discussion, Dong and John Considering the extra cost of method calls, the approach of adding an extra SourceReaderBase constructor should be a better choice. If there is no further discussion, I will follow this plan. Best, Wencong At 2023-01-08 01:05:07,

Re:Re: [DISCUSS] Allow source readers extending SourceReaderBase to override numRecordsIn report logic

2023-01-05 Thread Wencong Liu
Hi, All Thanks for the reply! I think both John and Dong's opinions are reasonable. John's Suggestion 2 is a good implementation. It does not affect the existing source connectors, but also provides support for custom counter in the future implementation. WDYT? Best, Wencong Liu