Re: Scala Style Template

2015-02-18 Thread Henry Saputra
We could help this by having shorter local and input argument names and better timing for the line wrapping. We already have separate code style for java, for example keeping tabs instead of spaces, and scala because java code more verbose and declarative compare to scala. I am ok with Java do

Re: Scala Style Template

2015-02-18 Thread Stephan Ewen
It is true, you can write endless chains of functions in Scala that become hard to read, which should be prevented. In my opinion, line length limits are not a good tool to do that. In most cases they simply introduce linebreaks between constant names and parameters which hurt code readability

Re: Scala Style Template

2015-02-18 Thread Henry Saputra
I would argue it is helpful especially if you use text editor like vim or even GitHub diff page. Most modern scala projects like spark and kafka also enforce the rule. - Henry On Wednesday, February 18, 2015, Stephan Ewen se...@apache.org wrote: It is true, you can write endless chains of

Re: Scala Style Template

2015-02-18 Thread Henry Saputra
Ah seemed like kafka has taken out the max line rule. I prefer to keep the max char lines, maybe making it larger than 100, especially with Scala code. On Wednesday, February 18, 2015, Henry Saputra henry.sapu...@gmail.com wrote: I would argue it is helpful especially if you use text editor

Re: Scala Style Template

2015-02-17 Thread Henry Saputra
Oh, since we are using tabs I think they are counted as one character? On Tuesday, February 17, 2015, Robert Metzger rmetz...@apache.org wrote: I agree with Stephan that we should remove the scalastyle rule enforcing lines of 100 characters length. On Mon, Jan 5, 2015 at 10:21 AM, Henry

Re: Scala Style Template

2015-02-17 Thread Henry Saputra
Sorry Robert and all, pressed Send button too early =( One of the main reasons to keep the max 100 chars line (or 120) is to make sure that the code is readable an understandable, which in Scala you can easily get the code to be complicated and in a single line. - Henry [1]

Re: Scala Style Template

2015-02-17 Thread Robert Metzger
I agree with Stephan that we should remove the scalastyle rule enforcing lines of 100 characters length. On Mon, Jan 5, 2015 at 10:21 AM, Henry Saputra henry.sapu...@gmail.com wrote: @Stephan - sure I could work on it. Been wanting to do it for a while. No, it is not the checkstyle issue.