Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-12 Thread Till Rohrmann
+1 for linking from DataSet's transformations. On Jun 12, 2015 5:27 PM, "Fabian Hueske" wrote: > Linking from the DataSet Transformations page would be good, IMO. > > 2015-06-12 17:11 GMT+02:00 Andra Lungu : > > > Thanks for the replies! > > > > I will add the two methods in a DataSetUtils separa

Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-12 Thread Fabian Hueske
Linking from the DataSet Transformations page would be good, IMO. 2015-06-12 17:11 GMT+02:00 Andra Lungu : > Thanks for the replies! > > I will add the two methods in a DataSetUtils separate class. Where would > you put the documentation for this? I think users should be able to easily > access i

Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-12 Thread Andra Lungu
Thanks for the replies! I will add the two methods in a DataSetUtils separate class. Where would you put the documentation for this? I think users should be able to easily access it. This means that it, IMO, it shouldn't go in a separate zip page, but rather in the programming guide. Or there coul

Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-10 Thread Till Rohrmann
I agree with Theo. I think it’s a nice feature to have as part of the standard API because only few users will be aware of something like DataSetUtils. However, as a first version we can make it part of DataSetUtils. Cheers, Till ​ On Wed, Jun 10, 2015 at 11:52 AM Theodore Vasiloudis < theodoros.

Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-10 Thread Theodore Vasiloudis
+1 for Fabian, but I would very much like to see this as part of the API in the future. This function would be very useful for FlinkML as well, as we noted in a recent discussion on the mailing list regarding time series datasets. On Wed, Jun 10, 2015 at 10:56 AM, Fabian Hueske wrote: > As Andr

Re: The correct location for zipWithIndex and zipWithUniqueId

2015-06-10 Thread Fabian Hueske
As Andra said, I'd would not add it to the API at this point. However, I don't think it should go into a separate Maven module (flink-contrib) that needs to be added as dependency but rather into some DataSetUtils class in flink-java. We can easily add it to the API later, if necessary. We should

The correct location for zipWithIndex and zipWithUniqueId

2015-06-10 Thread Andra Lungu
Hey everyone, We needed to assign unique labels as vertex values in Gelly at some point. We got a nice suggestion on how to do that in parallel (Implemented in https://github.com/apache/flink/pull/801#issuecomment-110654447). Now the question is where should these two functions go? Should they be