Re: [DISCUSS] Change some default config values of blocking shuffle

2021-12-13 Thread Jingsong Li
Hi Yingjie, Thanks for your explanation. I have no more questions. +1 On Tue, Dec 14, 2021 at 3:31 PM Yingjie Cao wrote: > > Hi Jingsong, > > Thanks for your feedback. > > >>> My question is, what is the maximum parallelism a job can have with the > >>> default configuration? (Does this break

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Konstantin Knauf
Hi Nicholas, I understand that a Rule contains more than the Pattern. Still, I favor DynamicPattern[Holder] over Rule, because the term "Rule" does not exist in Flink's CEP implementation so far and "dynamic" seems to be the important bit here. Cheers, Konstantin On Tue, Dec 14, 2021 at 4:46

Re: [DISCUSS] Change some default config values of blocking shuffle

2021-12-13 Thread Yingjie Cao
Hi Jingsong, Thanks for your feedback. >>> My question is, what is the maximum parallelism a job can have with the default configuration? (Does this break out of the box) Yes, you are right, these two options are related to network memory and framework off-heap memory. Generally, these changes

[jira] [Created] (FLINK-25294) Incorrect cloudpickle import

2021-12-13 Thread arya (Jira)
arya created FLINK-25294: Summary: Incorrect cloudpickle import Key: FLINK-25294 URL: https://issues.apache.org/jira/browse/FLINK-25294 Project: Flink Issue Type: Bug Components: API /

Re: [DISCUSS] Change some default config values of blocking shuffle

2021-12-13 Thread Jingsong Li
Hi Yingjie, +1 for this FLIP. I'm pretty sure this will greatly improve the ease of batch jobs. Looks like "taskmanager.memory.framework.off-heap.batch-shuffle.size" and "taskmanager.network.sort-shuffle.min-buffers" are related to network memory and framework.off-heap.size. My question is,

[jira] [Created] (FLINK-25293) Option to let fail if KafkaSource keeps failing to commit offset

2021-12-13 Thread rerorero (Jira)
rerorero created FLINK-25293: Summary: Option to let fail if KafkaSource keeps failing to commit offset Key: FLINK-25293 URL: https://issues.apache.org/jira/browse/FLINK-25293 Project: Flink

[jira] [Created] (FLINK-25292) Azure failed due to unable to fetch some archives

2021-12-13 Thread Yun Gao (Jira)
Yun Gao created FLINK-25292: --- Summary: Azure failed due to unable to fetch some archives Key: FLINK-25292 URL: https://issues.apache.org/jira/browse/FLINK-25292 Project: Flink Issue Type: Bug

Re: [DISCUSS] Change some default config values of blocking shuffle

2021-12-13 Thread Yingjie Cao
Hi Jiangang, Thanks for your suggestion. >>> The config can affect the memory usage. Will the related memory configs be changed? I think we will not change the default network memory settings. My best expectation is that the default value can work for most cases (though may not the best) and

Re: [DISCUSS] Change some default config values of blocking shuffle

2021-12-13 Thread Yingjie Cao
Hi Yun, Thanks for your feedback. I think setting taskmanager.network.sort-shuffle.min-parallelism to 1 and using sort-shuffle for all cases by default is a good suggestion. I am not choosing this value mainly because two reasons: 1. The first one is that it increases the usage of network

[jira] [Created] (FLINK-25291) Add failure cases in DataStream source and sink suite of connector testing framework

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25291: - Summary: Add failure cases in DataStream source and sink suite of connector testing framework Key: FLINK-25291 URL: https://issues.apache.org/jira/browse/FLINK-25291

[jira] [Created] (FLINK-25290) Add table source and sink test suite in connector testing framework

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25290: - Summary: Add table source and sink test suite in connector testing framework Key: FLINK-25290 URL: https://issues.apache.org/jira/browse/FLINK-25290 Project: Flink

[jira] [Created] (FLINK-25288) Add savepoint and metric cases in DataStream source suite of connector testing framework

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25288: - Summary: Add savepoint and metric cases in DataStream source suite of connector testing framework Key: FLINK-25288 URL: https://issues.apache.org/jira/browse/FLINK-25288

[jira] [Created] (FLINK-25289) Add DataStream sink test suite in connector testing framework

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25289: - Summary: Add DataStream sink test suite in connector testing framework Key: FLINK-25289 URL: https://issues.apache.org/jira/browse/FLINK-25289 Project: Flink

[jira] [Created] (FLINK-25287) Refactor connector testing framework interfaces

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25287: - Summary: Refactor connector testing framework interfaces Key: FLINK-25287 URL: https://issues.apache.org/jira/browse/FLINK-25287 Project: Flink Issue

[jira] [Created] (FLINK-25286) Improve connector testing framework to support more scenarios

2021-12-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-25286: - Summary: Improve connector testing framework to support more scenarios Key: FLINK-25286 URL: https://issues.apache.org/jira/browse/FLINK-25286 Project: Flink

Re: [Proposal] It is hoped that Apache APISIX and Apache Flink will carry out diversified community cooperation

2021-12-13 Thread Ming Wen
Hi, yeliang, Apache ML does not support pictures and attachments, so we can not see the architecture diagram. I think it will work between Flink and APISIX from your description. Thanks, Ming Wen, Apache APISIX PMC Chair Twitter: _WenMing yeliang wang 于2021年12月14日周二 12:05写道: > Hi,

[Proposal] It is hoped that Apache APISIX and Apache Flink will carry out diversified community cooperation

2021-12-13 Thread yeliang wang
Hi, community, My name is Yeliang Wang, and I am Apache APISIX Committer. In my knowledge field, Apache Flink as a distributed real-time processing engine for stream data and batch data with high throughput and low latency, has a very rich application scenario in enterprises. For example, in

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Yun Tang
Hi Chesnay, Thanks a lot for driving these emergency patch releases! I just noticed that current flink-1.11.4 offers python files on mac os [1]. Is it okay to release Flink-1.11.5 and flink-1.12.6 without those python binaries on mac os? [1]

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Nicholas Jiang
Hi DianFu, Thanks for your feedback of the FLIP. About the mentioned question for the `getLatestRules`, IMO, this doesn't need to rename into `getRuleChanges` because this method is used for getting the total amount of the latest rules which has been updated once.

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Prasanna kumar
It would be good if docker images are released too . Prasanna. On Mon, 13 Dec 2021, 16:16 Jing Zhang, wrote: > +1 for the quick release. > > Till Rohrmann 于2021年12月13日周一 17:54写道: > > > +1 > > > > Cheers, > > Till > > > > On Mon, Dec 13, 2021 at 10:42 AM Jing Ge wrote: > > > > > +1 > > > > >

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Zhu Zhu
+1 (binding) - verified the differences of source releases to the corresponding latest releases, there are only dependency updates and release version update commits - verified versions of log4j dependencies in the all binary releases are 2.15.0 - ran example jobs against all the binary releases,

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Xintong Song
+1 (binding) - verified checksum and signature - verified that release candidates only contain the log4j dependency changes compared to previous releases. - release notes and blogpost LGTM Thanks a lot for driving these emergency patch releases, Chesnay! Thank you~ Xintong Song On Tue, Dec

[jira] [Created] (FLINK-25285) CoGroupedStreams has inner Maps without easy ways to set uid

2021-12-13 Thread Daniel Bosnic Hill (Jira)
Daniel Bosnic Hill created FLINK-25285: -- Summary: CoGroupedStreams has inner Maps without easy ways to set uid Key: FLINK-25285 URL: https://issues.apache.org/jira/browse/FLINK-25285 Project:

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Chesnay Schepler
I forgot to mention something important: The 1.11/1.12 releases do *NOT* contain flink-python releases for *mac* due to compile problems. On 13/12/2021 20:28, Chesnay Schepler wrote: Hi everyone, This vote is for the emergency patch releases for 1.11, 1.12, 1.13 and 1.14 to address

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Chesnay Schepler
Update: All jars are now available. On 13/12/2021 20:28, Chesnay Schepler wrote: Hi everyone, This vote is for the emergency patch releases for 1.11, 1.12, 1.13 and 1.14 to address CVE-2021-44228. It covers all 4 releases as they contain the same changes (upgrading Log4j to 2.15.0) and were

[jira] [Created] (FLINK-25284) Support nulls in DataGen

2021-12-13 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-25284: --- Summary: Support nulls in DataGen Key: FLINK-25284 URL: https://issues.apache.org/jira/browse/FLINK-25284 Project: Flink Issue Type: Bug

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Stephan Ewen
+1 (binding) - Verified that commit history is identical to previous release (except dependency upgrade and release version commit) - Verified that the source releases reference updated dependency and binary releases contain updated dependency - Blog post looks good - ran bundled examples

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Seth Wiesman
+1 (non-binding) - Checked Log4J version and updated license preambles on all releases - Verified signatures on sources - Reviewed blog post Seth On Mon, Dec 13, 2021 at 1:42 PM Jing Ge wrote: > +1 LGTM. Many thanks for your effort! > > On Mon, Dec 13, 2021 at 8:28 PM Chesnay Schepler >

[jira] [Created] (FLINK-25283) End-to-end application modules create oversized jars

2021-12-13 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-25283: Summary: End-to-end application modules create oversized jars Key: FLINK-25283 URL: https://issues.apache.org/jira/browse/FLINK-25283 Project: Flink

Re: [VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Jing Ge
+1 LGTM. Many thanks for your effort! On Mon, Dec 13, 2021 at 8:28 PM Chesnay Schepler wrote: > Hi everyone, > > This vote is for the emergency patch releases for 1.11, 1.12, 1.13 and > 1.14 to address CVE-2021-44228. > It covers all 4 releases as they contain the same changes (upgrading >

[VOTE] Release 1.11.5/1.12.6/1.13.4/1.14.1, release candidate #1

2021-12-13 Thread Chesnay Schepler
Hi everyone, This vote is for the emergency patch releases for 1.11, 1.12, 1.13 and 1.14 to address CVE-2021-44228. It covers all 4 releases as they contain the same changes (upgrading Log4j to 2.15.0) and were prepared simultaneously by the same person. (Hence, if something is broken, it

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-13 Thread Marios Trivyzas
@Timo Walther > But the question is why a user wants to run COMPILE multiple times. If > it is during development, then running EXECUTE (or just the statement > itself) without calling COMPILE should be sufficient. The file can also > manually be deleted if necessary. Sorry for the delayed

Re: [DISCUSS] FLIP-191: Extend unified Sink interface to support small file compaction

2021-12-13 Thread Fabian Paul
Hi all, After a lot of discussions with different, we received very fruitful feedback and reworked the ideas behind this FLIP. Initially, we had the impression that the compaction problem is solvable by a single topology that we can reuse across different sinks. We now have a better understanding

[jira] [Created] (FLINK-25282) Move runtime dependencies from table-planner to table-runtime

2021-12-13 Thread Francesco Guardiani (Jira)
Francesco Guardiani created FLINK-25282: --- Summary: Move runtime dependencies from table-planner to table-runtime Key: FLINK-25282 URL: https://issues.apache.org/jira/browse/FLINK-25282 Project:

[jira] [Created] (FLINK-25281) Azure failed due to python tests "tox check failed"

2021-12-13 Thread Yun Gao (Jira)
Yun Gao created FLINK-25281: --- Summary: Azure failed due to python tests "tox check failed" Key: FLINK-25281 URL: https://issues.apache.org/jira/browse/FLINK-25281 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-25280) KafkaPartitionSplitReaderTest failed on azure due to Offsets out of range with no configured reset policy for partitions

2021-12-13 Thread Yun Gao (Jira)
Yun Gao created FLINK-25280: --- Summary: KafkaPartitionSplitReaderTest failed on azure due to Offsets out of range with no configured reset policy for partitions Key: FLINK-25280 URL:

[jira] [Created] (FLINK-25279) KafkaSourceLegacyITCase.testKeyValueSupport failed on azure due to topic already exists

2021-12-13 Thread Yun Gao (Jira)
Yun Gao created FLINK-25279: --- Summary: KafkaSourceLegacyITCase.testKeyValueSupport failed on azure due to topic already exists Key: FLINK-25279 URL: https://issues.apache.org/jira/browse/FLINK-25279

[jira] [Created] (FLINK-25278) Azure failed due to unable to transfer jar from confluent maven repo

2021-12-13 Thread Yun Gao (Jira)
Yun Gao created FLINK-25278: --- Summary: Azure failed due to unable to transfer jar from confluent maven repo Key: FLINK-25278 URL: https://issues.apache.org/jira/browse/FLINK-25278 Project: Flink

[jira] [Created] (FLINK-25277) Introduce explicit shutdown signalling between TaskManager and JobManager

2021-12-13 Thread Niklas Semmler (Jira)
Niklas Semmler created FLINK-25277: -- Summary: Introduce explicit shutdown signalling between TaskManager and JobManager Key: FLINK-25277 URL: https://issues.apache.org/jira/browse/FLINK-25277

[jira] [Created] (FLINK-25276) Support native and incremental savepoints

2021-12-13 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-25276: -- Summary: Support native and incremental savepoints Key: FLINK-25276 URL: https://issues.apache.org/jira/browse/FLINK-25276 Project: Flink Issue Type:

[jira] [Created] (FLINK-25275) Weighted KeyGroup assignment

2021-12-13 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-25275: -- Summary: Weighted KeyGroup assignment Key: FLINK-25275 URL: https://issues.apache.org/jira/browse/FLINK-25275 Project: Flink Issue Type: New Feature

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Dian Fu
Thanks Yunfeng for bringing up this discussion. I have seen that there were many users asking for this feature in the past. So big +1 for this proposal. Regarding this FLIP, I have the following question: - Does it make sense to rename the method `getLatestRules` into `getRuleChanges`? I assume

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Yunfeng Zhou
Hi Konstantin, Thanks for your suggestion. For the first idea, I agree that adding a timestamp field and making users able to schedule a rule is a useful feature. This might not require too much implementation work and I believe it can be achieved in this FLIP. As for the second idea, Rule is a

[jira] [Created] (FLINK-25274) Use ResolvedSchema in DataGen instead of TableSchema

2021-12-13 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-25274: --- Summary: Use ResolvedSchema in DataGen instead of TableSchema Key: FLINK-25274 URL: https://issues.apache.org/jira/browse/FLINK-25274 Project: Flink

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Jing Zhang
+1 for the quick release. Till Rohrmann 于2021年12月13日周一 17:54写道: > +1 > > Cheers, > Till > > On Mon, Dec 13, 2021 at 10:42 AM Jing Ge wrote: > > > +1 > > > > As I suggested to publish the blog post last week asap, users have been > > keen to have such urgent releases. Many thanks for it. > > >

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Ada Luna
+1 I need 1.12.6, thanks Till Rohrmann 于2021年12月13日周一 17:54写道: > > +1 > > Cheers, > Till > > On Mon, Dec 13, 2021 at 10:42 AM Jing Ge wrote: > > > +1 > > > > As I suggested to publish the blog post last week asap, users have been > > keen to have such urgent releases. Many thanks for it. > > >

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-13 Thread Jing Zhang
Hi Timo, +1 for the improvement too. Please count me in when assign subtasks. Best, Jing Zhang Timo Walther 于2021年12月13日周一 17:00写道: > Hi everyone, > > *last call for feedback* on this FLIP. Otherwise I would start a VOTE by > tomorrow. > > @Wenlong: Thanks for offering your help. Once the

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Till Rohrmann
+1 Cheers, Till On Mon, Dec 13, 2021 at 10:42 AM Jing Ge wrote: > +1 > > As I suggested to publish the blog post last week asap, users have been > keen to have such urgent releases. Many thanks for it. > > > > On Mon, Dec 13, 2021 at 8:29 AM Konstantin Knauf > wrote: > > > +1 > > > > I didn't

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Nicholas Jiang
Hi Konstantin, About the renaming for the Rule, I mean that the difference between the Rule and Pattern is that the Rule not only contains the Pattern, but also how to match the Pattern, and how to process after matched. If renaming DynamicPattern, I'm concerned that this name couldn't

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Jing Ge
+1 As I suggested to publish the blog post last week asap, users have been keen to have such urgent releases. Many thanks for it. On Mon, Dec 13, 2021 at 8:29 AM Konstantin Knauf wrote: > +1 > > I didn't think this was necessary when I published the blog post on Friday, > but this has made

Re: [DISCUSS] Immediate dedicated Flink releases for log4j vulnerability

2021-12-13 Thread Chesnay Schepler
I will start preparing the release candidates. On 12/12/2021 23:23, Stephan Ewen wrote: Hi all! Without doubt, you heard about the log4j vulnerability [1]. There is an advisory blog post on how to mitigate this in Apache Flink [2], which involves setting a config option and restarting the

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-13 Thread Timo Walther
Hi everyone, *last call for feedback* on this FLIP. Otherwise I would start a VOTE by tomorrow. @Wenlong: Thanks for offering your help. Once the FLIP has been accepted. I will create a list of subtasks that we can split among contributors. Many can be implemented in parallel. Regards,

Re: [VOTE] FLIP-196: Source API stability guarantees

2021-12-13 Thread Chesnay Schepler
+1 On 10/12/2021 18:07, Till Rohrmann wrote: Hi everyone, I'd like to start a vote on FLIP-196: Source API stability guarantees [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1]

Re: [VOTE] FLIP-197: API stability graduation process

2021-12-13 Thread Chesnay Schepler
+1 On 10/12/2021 18:09, Till Rohrmann wrote: Hi everyone, I'd like to start a vote on FLIP-197: API stability graduation process [1] which has been discussed in this thread [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1]

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Konstantin Knauf
Hi Nicholas, I am not sure I understand your question about renaming. I think the most important member of the current Rule class is the Pattern, the KeySelector and PatternProcessFunction are more auxiliary if you will. That's why, I think, it would be ok to rename Rule to DynamicPatternHolder

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-13 Thread wenlong.lwl
Hi, Timo, +1 for the improvement too. Thanks for the great job. Looking forward to the next progress of the FLIP, I could help on the development of some of the specific improvements. Best, Wenlong On Mon, 13 Dec 2021 at 14:43, godfrey he wrote: > Hi Timo, > > +1 for the improvement. > >

Re: [DISCUSS] FLIP-200: Support Multiple Rule and Dynamic Rule Changing (Flink CEP)

2021-12-13 Thread Nicholas Jiang
Hi Konstantin, Thanks for your feedback. The point that add a timestamp to each rule that determines the start time from which the rule makes sense to me. At present, The timestamp is current time at default, so no timestamp field represents the start time from which the rule. And about the