Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

Thanks Peter for driving this. The FLIP change is a big improvement of the existing sink v2 interfaces, but the FLIP's overall API design taste and interface style looks good to me. +1(binding) from my side. I also left a little minor comments we can improve later. (1) The FLIP title dosen't

Re: Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

Thanks for the FLIP. +1 (non-binding) Best, Hang Jiabao Sun 于2023年12月21日周四 11:48写道： > Thanks Peter for driving this. > > +1 (non-binding) > > Best, > Jiabao > > > On 2023/12/18 12:06:05 Gyula Fóra wrote: > > +1 (binding) > > > > Gyula > > > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > >

Re: [VOTE] FLIP-364: Update the default value of backoff-multiplier from 1.2 to 1.5

+1 (non-binding) Best, Jiabao > 2023年12月21日 13:25，weijie guo 写道： > > +1(binding) > > Best regards, > > Weijie > > > Xin Jiang 于2023年12月21日周四 11:21写道： > >> 1.5 multiplier is indeed more reasonable. >> >> +1 (non-binding) >> >>> 2023年12月19日 下午5:17，Rui Fan <1996fan...@gmail.com> 写道： >>>

Re: [VOTE] FLIP-364: Update the default value of backoff-multiplier from 1.2 to 1.5

+1(binding) Best regards, Weijie Xin Jiang 于2023年12月21日周四 11:21写道： > 1.5 multiplier is indeed more reasonable. > > +1 (non-binding) > > > 2023年12月19日 下午5:17，Rui Fan <1996fan...@gmail.com> 写道： > > > > Hi everyone, > > > > Thank you to everyone for the feedback on FLIP-364: > > Improve the

Re: [DISCUSS] Should Configuration support getting value based on String key?

Sounds make sense. We will do it in the FLIP. Best, Rui On Thu, 21 Dec 2023 at 10:20, Xintong Song wrote: > Ideally, public API changes should go through the FLIP process. > > I see the point that starting a FLIP for such a tiny change might be > overkill. However, one could also argue that

Re: [VOTE] Release 1.18.1, release candidate #2

Thanks Jing Ge for driving this release. +1 (non-binding), I have checked: [✓] The checksums and signatures are validated [✓] The tag checked is fine [✓] Built from source is passed [✓] The flink-web PR is reviewed and checked Best， Zhongqiang Gong

RE: Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

Thanks Peter for driving this. +1 (non-binding) Best, Jiabao On 2023/12/18 12:06:05 Gyula Fóra wrote: > +1 (binding) > > Gyula > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > wrote: > > > +1 (binding) > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > wrote: > > > > > Hi everyone, >

Re: [VOTE] FLIP-364: Update the default value of backoff-multiplier from 1.2 to 1.5

1.5 multiplier is indeed more reasonable. +1 (non-binding) > 2023年12月19日 下午5:17，Rui Fan <1996fan...@gmail.com> 写道： > > Hi everyone, > > Thank you to everyone for the feedback on FLIP-364: > Improve the restart-strategy[1] which has been voted in this thread[2]. > > After the vote on FLIP-364,

Re:Re: [DISCUSS] FLIP-387: Support named parameters for functions and call procedures

Hi, Benchao. When Feng Jin and I tried the poc together, we found that when using udaf, Calcite directly using the function's input parameters from SqlCall#getOperandList. But in fact, these input parameters may use named arguments, the order of parameters may be wrong, and they may not

Re: [DISCUSS] Should Configuration support getting value based on String key?

Ideally, public API changes should go through the FLIP process. I see the point that starting a FLIP for such a tiny change might be overkill. However, one could also argue that anything that is too trivial to go through a FLIP should also be easy enough to quickly get through the process. In

Re:Re: [VOTE] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

Thanks for driving this FLIP, +1 for it (non binding) -- Best！ Xuyang 在 2023-12-21 06:08:02，"Natea Eshetu Beshada" 写道： >Thanks for the FLIP Alan, this will be a great addition +1 (non binding) > >On Wed, Dec 20, 2023 at 11:41 AM Alan Sheinberg > wrote: > >> Hi everyone, >> >>

Re: [DISCUSS] Release flink-connector-mongodb v1.1.0

Thanks Jiabao for driving this. +1 to release flink-connector-mongodb v1.1.0 which supports Flink 1.18 and Flink 1.17. I’d like to help review the pending PRs and manage the release as well. Best, Leonard > 2023年12月20日 下午9:59，Jiabao Sun 写道： > > Hi, > > Now Flink 1.18 is released. I

Re: [DISCUSS] FLIP-389: Annotate SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving

Hi Hongshun, I think the proposal in the FLIP is basically fine. A few minor comments: 1. In FLIPs, we define all the user-sensible changes as public interfaces. The public interface section should list all of them. So, the code blocks currently in the proposed changes section should be put into

Re: [VOTE] Release flink-connector-pulsar 4.1.0, release candidate #1

+1 (non-binding) - Downloaded artifacts - Maven staging artifacts look good - Verified checksum && keys - Verified LICENSE and NOTICE files - Built from source On Wed, Dec 20, 2023 at 5:13 AM tison wrote: > Hi Leonard, > > You are a PMC member also. Perhaps you can check the candidate and >

Re: [VOTE] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

Thanks for the FLIP Alan, this will be a great addition +1 (non binding) On Wed, Dec 20, 2023 at 11:41 AM Alan Sheinberg wrote: > Hi everyone, > > I'd like to start a vote on FLIP-400 [1]. It covers introducing a new UDF > type, AsyncScalarFunction for completing invocations asynchronously. It

[jira] [Created] (FLINK-33919) AutoRescalingITCase hangs on AZP

Sergey Nuyanzin created FLINK-33919: --- Summary: AutoRescalingITCase hangs on AZP Key: FLINK-33919 URL: https://issues.apache.org/jira/browse/FLINK-33919 Project: Flink Issue Type:

[VOTE] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

Hi everyone, I'd like to start a vote on FLIP-400 [1]. It covers introducing a new UDF type, AsyncScalarFunction for completing invocations asynchronously. It has been discussed in this thread [2]. I would like to start a vote. The vote will be open for at least 72 hours (until December 28th

[jira] [Created] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

Jim Hughes created FLINK-33918: -- Summary: Fix AsyncSinkWriterThrottlingTest test failure Key: FLINK-33918 URL: https://issues.apache.org/jira/browse/FLINK-33918 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

I'm delighted to see the progress on this. This is going to be a major enabler for some important use cases. The proposed simplifications (global config and ordered mode) for V1 make a lot of sense to me. +1 David On Wed, Dec 20, 2023 at 12:31 PM Alan Sheinberg wrote: > Thanks for that

[jira] [Created] (FLINK-33917) IllegalArgumentException: hostname can't be null

Tom created FLINK-33917: --- Summary: IllegalArgumentException: hostname can't be null Key: FLINK-33917 URL: https://issues.apache.org/jira/browse/FLINK-33917 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

Thanks for that feedback Lincoln, Only one question with the async `timeout` parameter[1](since I > haven't seen the POC code), current description is: 'The time which can > pass before a restart strategy is triggered', > but in the previous flip-232[2] and flip-234[3], in retry scenario, this >

Re: [VOTE] Release 1.18.1, release candidate #2

+1 (non-binding) - Validated hashes - Verified signature - Build the source with Maven - Test with the kafka connector 3.0.2: read and write records from kafka in sql client - Verified web PRs Best, Hang Jiabao Sun 于2023年12月20日周三 16:57写道： > Thanks Jing for driving this release. > > +1

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

Hi, Thank you to everyone for the discussion on this FLIP, especially Becket for providing guidance that made it more reasonable. The FLIP document[1] has been updated with the recent discussed content. Please take a look to double-check it when you have time. If we can reach a consensus on

[DISCUSS] Release flink-connector-mongodb v1.1.0

Hi, Now Flink 1.18 is released. I propose to release flink-connector-mongodb v1.1.0 to support Flink 1.18 and nominate Leonard Xu as the release manager. This release includes support for filter pushdown[1] and JDK 17[2]. We plan to proceed with the release after merging these two pull

Re: [DISCUSS] Should Configuration support getting value based on String key?

Thanks Xuannan and Xintong for the quick feedback! > However, we should let the user know that we encourage using ConfigOptions over the string-based > configuration key, as Timo said, we should add the message to `String > getString(String key, String defaultValue)` method. Sure, we can add

Re: [DISCUSS] FLIP-398: Improve Serialization Configuration And Usage In Flink

Hi Ken, Thanks for your feedback. The purpose of this FLIP is to improve the use of serialization, including configurable serializer for users, providing serializer for composite data types, and resolving the default enabling of Kryo, etc. Introducing a better serialization framework would be a

[jira] [Created] (FLINK-33916) Workflow: Add nightly build for release-1.18

Matthias Pohl created FLINK-33916: - Summary: Workflow: Add nightly build for release-1.18 Key: FLINK-33916 URL: https://issues.apache.org/jira/browse/FLINK-33916 Project: Flink Issue Type:

[jira] [Created] (FLINK-33915) Workflow: Add nightly build for the dev version (currently called "master")

Matthias Pohl created FLINK-33915: - Summary: Workflow: Add nightly build for the dev version (currently called "master") Key: FLINK-33915 URL: https://issues.apache.org/jira/browse/FLINK-33915

[jira] [Created] (FLINK-33913) Template: Add CI template for running Flink's test suite

Matthias Pohl created FLINK-33913: - Summary: Template: Add CI template for running Flink's test suite Key: FLINK-33913 URL: https://issues.apache.org/jira/browse/FLINK-33913 Project: Flink

[jira] [Created] (FLINK-33914) Workflow: Add basic CI that will run with the default configuration

Matthias Pohl created FLINK-33914: - Summary: Workflow: Add basic CI that will run with the default configuration Key: FLINK-33914 URL: https://issues.apache.org/jira/browse/FLINK-33914 Project: Flink

[jira] [Created] (FLINK-33912) Template: Add CI template for pre-compile steps

Matthias Pohl created FLINK-33912: - Summary: Template: Add CI template for pre-compile steps Key: FLINK-33912 URL: https://issues.apache.org/jira/browse/FLINK-33912 Project: Flink Issue

[jira] [Created] (FLINK-33911) Custom Action: Select workflow configuration

Matthias Pohl created FLINK-33911: - Summary: Custom Action: Select workflow configuration Key: FLINK-33911 URL: https://issues.apache.org/jira/browse/FLINK-33911 Project: Flink Issue Type:

[jira] [Created] (FLINK-33910) Custom Action: Enable Java version in Flink's CI Docker image

Matthias Pohl created FLINK-33910: - Summary: Custom Action: Enable Java version in Flink's CI Docker image Key: FLINK-33910 URL: https://issues.apache.org/jira/browse/FLINK-33910 Project: Flink

[jira] [Created] (FLINK-33909) Custom Action: Select the right branch and commit hash

Matthias Pohl created FLINK-33909: - Summary: Custom Action: Select the right branch and commit hash Key: FLINK-33909 URL: https://issues.apache.org/jira/browse/FLINK-33909 Project: Flink

[jira] [Created] (FLINK-33908) Custom Action: Move files within the Docker image to the root folder to match the user

Matthias Pohl created FLINK-33908: - Summary: Custom Action: Move files within the Docker image to the root folder to match the user Key: FLINK-33908 URL: https://issues.apache.org/jira/browse/FLINK-33908

[jira] [Created] (FLINK-33907) Makes copying test jars being done earlier

Matthias Pohl created FLINK-33907: - Summary: Makes copying test jars being done earlier Key: FLINK-33907 URL: https://issues.apache.org/jira/browse/FLINK-33907 Project: Flink Issue Type:

[jira] [Created] (FLINK-33906) tools/azure-pipelines/debug_files_utils.sh should support GHA output as well

Matthias Pohl created FLINK-33906: - Summary: tools/azure-pipelines/debug_files_utils.sh should support GHA output as well Key: FLINK-33906 URL: https://issues.apache.org/jira/browse/FLINK-33906

[jira] [Created] (FLINK-33905) FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

Wencong Liu created FLINK-33905: --- Summary: FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs Key: FLINK-33905 URL: https://issues.apache.org/jira/browse/FLINK-33905 Project: Flink

[jira] [Created] (FLINK-33904) Add zip as a package to GitHub Actions runners

Matthias Pohl created FLINK-33904: - Summary: Add zip as a package to GitHub Actions runners Key: FLINK-33904 URL: https://issues.apache.org/jira/browse/FLINK-33904 Project: Flink Issue

[jira] [Created] (FLINK-33903) Reenable tests that edit file permissions

Matthias Pohl created FLINK-33903: - Summary: Reenable tests that edit file permissions Key: FLINK-33903 URL: https://issues.apache.org/jira/browse/FLINK-33903 Project: Flink Issue Type:

[jira] [Created] (FLINK-33902) Switch to OpenSSL legacy algorithms

Matthias Pohl created FLINK-33902: - Summary: Switch to OpenSSL legacy algorithms Key: FLINK-33902 URL: https://issues.apache.org/jira/browse/FLINK-33902 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33901) Trial Period: GitHub Actions

Matthias Pohl created FLINK-33901: - Summary: Trial Period: GitHub Actions Key: FLINK-33901 URL: https://issues.apache.org/jira/browse/FLINK-33901 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-33900) Multiple failures in WindowRankITCase due to NoResourceAvailableException

Matthias Pohl created FLINK-33900: - Summary: Multiple failures in WindowRankITCase due to NoResourceAvailableException Key: FLINK-33900 URL: https://issues.apache.org/jira/browse/FLINK-33900 Project:

[jira] [Created] (FLINK-33899) Java 17 and 21 support for mongodb connector

Jiabao Sun created FLINK-33899: -- Summary: Java 17 and 21 support for mongodb connector Key: FLINK-33899 URL: https://issues.apache.org/jira/browse/FLINK-33899 Project: Flink Issue Type:

[jira] [Created] (FLINK-33898) Allow triggering unaligned checkpoint via REST api

Zakelly Lan created FLINK-33898: --- Summary: Allow triggering unaligned checkpoint via REST api Key: FLINK-33898 URL: https://issues.apache.org/jira/browse/FLINK-33898 Project: Flink Issue Type:

[jira] [Created] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

Zakelly Lan created FLINK-33897: --- Summary: Allow triggering unaligned checkpoint via CLI Key: FLINK-33897 URL: https://issues.apache.org/jira/browse/FLINK-33897 Project: Flink Issue Type:

Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

+1 for this useful feature! Hope this reply isn't too late. Agree that we start with global async-scalar configuration and ordered mode first. @Alan Only one question with the async `timeout` parameter[1](since I haven't seen the POC code), current description is: 'The time which can pass before

[jira] [Created] (FLINK-33896) Implement restore tests for Correlate node

Jacky Lau created FLINK-33896: - Summary: Implement restore tests for Correlate node Key: FLINK-33896 URL: https://issues.apache.org/jira/browse/FLINK-33896 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33895) Implement restore tests for PythonGroupWindowAggregate node

Jacky Lau created FLINK-33895: - Summary: Implement restore tests for PythonGroupWindowAggregate node Key: FLINK-33895 URL: https://issues.apache.org/jira/browse/FLINK-33895 Project: Flink Issue

[jira] [Created] (FLINK-33894) Implement restore tests for PythonGroupAggregate node

Jacky Lau created FLINK-33894: - Summary: Implement restore tests for PythonGroupAggregate node Key: FLINK-33894 URL: https://issues.apache.org/jira/browse/FLINK-33894 Project: Flink Issue Type:

[jira] [Created] (FLINK-33893) Implement restore tests for PythonCorrelate node

Jacky Lau created FLINK-33893: - Summary: Implement restore tests for PythonCorrelate node Key: FLINK-33893 URL: https://issues.apache.org/jira/browse/FLINK-33893 Project: Flink Issue Type:

Re: [VOTE] Release 1.18.1, release candidate #2

Thanks Jing for driving this release. +1 (non-binding) - Validated hashes - Verified signature - Checked the tag - Build the source with Maven - Verified web PRs Best, Jiabao > 2023年12月20日 07:38，Jing Ge 写道： > > Hi everyone, > > The release candidate #1 has been skipped. Please review and

Re: [DISCUSS] Should Configuration support getting value based on String key?

Sounds good to me. Best, Xintong On Wed, Dec 20, 2023 at 9:40 AM Xuannan Su wrote: > Hi Rui, > > I am fine with keeping the `String getString(String key, String > defaultValue)` if more people favor it. However, we should let the > user know that we encourage using ConfigOptions over the

[RESULT][VOTE] FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

The vote for FLIP-382 [1]: Unify the Provision of Diverse Metadata for Context-like APIs (discussion thread [2]) concluded. The vote will be closed.[3]. There are 3 binding votes and 1 non-binding votes: Xintong Song (binding) Lijie Wang (binding) Weijie Guo (binding) Yuxin Tan (non-binding)

[RESULT][VOTE] FLIP-380: Support Full Partition Processing On Non-keyed DataStream

The vote for FLIP-380 [1]: Support Full Partition Processing On Non-keyed DataStream (discussion thread [2]) concluded. The vote will be closed.[3]. There are 3 binding votes and 1 non-binding votes: Xintong Song (binding) YingJie Cao (binding) Weijie Guo (binding) Yuxin Tan (non-binding)