Hi all,
Thanks for all of your quick response! I will bring up the VOTE.
Best,
Wei
> 在 2019年12月5日,10:39,Jark Wu 写道:
>
> Hi Wei,
>
> Thanks for bringing this discussion up, the changes look good to me.
> Looking forward to the vote. And you can prepare the pull request at the
> same time (in
Hi Wei,
Thanks for bringing this discussion up, the changes look good to me.
Looking forward to the vote. And you can prepare the pull request at the
same time (in order to checkin in time).
Best,
Jark
On Thu, 5 Dec 2019 at 10:27, Hequn Cheng wrote:
> Hi all,
>
> Thanks a lot for the
Hi all,
Thanks a lot for the discussion! Using "#" also makes sense to me.
And +1 to have these improvements in 1.10 as we don't want to
introduce compatibility problems later.
Looking forward to the vote!
Best, Hequn
On Thu, Dec 5, 2019 at 10:02 AM jincheng sun
wrote:
> Hi all,
>
> Thanks
Thanks for bringing up this discussion Wei. +1 for this proposal!
As these options are proposed in 1.10, it will be great if we can improve them
in 1.10. Then it will not cause compatible issues.
Thanks,
Dian
> 在 2019年12月5日,上午10:01,jincheng sun 写道:
>
> Hi all,
>
> Thanks for the quick
Hi all,
Thanks for the quick response Aljoscha & Wei !
It seems unify the options is necessary, and 1.10 will be code frozen. I
would be like to bring up the VOTE thread for this change ASAP, and more
detail can continue discuss in the PR.
What do you think?
Best,
Jincheng
Aljoscha Krettek
Perfect, thanks for the background info! I also found this section now, which
mentions that it comes from Hadoop:
https://spark.apache.org/docs/latest/running-on-yarn.html#important-notes.
I think the proposed changes are good!
Best,
Aljoscha
> On 4. Dec 2019, at 04:34, Wei Zhong wrote:
>
>
Hi Aljoscha,
Thanks for your reply! Before bringing up this discussion I did some research
on commonly used separators for options that take multiple values. I have
considered ",", ":" and "#". Finally I chose "#" as the separator of
"--pyRequirements".
For ",", it is the most widely used
Hi,
Yes, I think it’s a good idea to make the options uniform. Using ‘#’ as a
separator for options that take two values seems a bit strange to me, did you
research if any other CLI tools have this convention?
Side note: I don’t like that our options use camel-case, I think that’s very
Thanks for bringup this discussion Wei!
I think this is very important for Flink User, we should contains this
changes in Flink 1.10.
+1 for the optimization from the perspective of user convenience and the
unified use of Flink command line parameters.
Best,
Jincheng
Wei Zhong 于2019年12月2日周一