Re: [DISCUSS] Add custom labels on AbstractPrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Hi jinhai, I think it is a good improvement to also add groupingKey to PrometheusReporter.And making the PrometheusPushGatewayReporter and PrometheusReporter always share the same logics is important. AFAIK, they should not have differences except for the metrics exposing mechanism

[DISCUSS] Add custom labels on AbstractPrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Hi all I'd like to start the discussion about Prometheus labelNames. We need to add some custom labels on Prometheus, so we can query by them. We can add groupingKey to PrometheusPushGatewayReporter in version 1.10, but not in PrometheusReporter. Can we add abstract addLabels method on