Re: [DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-12-01 Thread Zhenghua Gao
Since it is unanimously agreed that we should disable conversion between Timestmap and long in parameters and results of UDXs, in PR [1] we will disable it in blink planner. And we will add a release note in FLINK-14599 [2] of this incompatible modification.

Re: [DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-11-24 Thread Jark Wu
Hi, +1 to disable it in 1.10. I think it's time to disable and correct the behavior now. Also cc'ed user mailing list to have broader audiences. Best, Jark On Sat, 23 Nov 2019 at 16:59, Timo Walther wrote: > Hi, > > +1 for disabling it in the Blink planner. Once FLIP-65 is implemented > and

Re: [DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-11-23 Thread Timo Walther
Hi, +1 for disabling it in the Blink planner. Once FLIP-65 is implemented and a UDX is registered with the new TableEnvironment.createTemporaryFunction() we will also have the possibility to be fully compliant with the new type system because we can advertise a new UDF stack with new

Re: [DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-11-22 Thread Jingsong Li
+1 to disable, It is already introduced by new type system in TimestampType. I think it is time to update document too. Best, Jingsong Lee On Fri, Nov 22, 2019 at 6:05 PM Kurt Young wrote: > +1 to disable, we also need to highlight this in 1.10 release notes. > > Best, > Kurt > > > On Fri, Nov

Re: [DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-11-22 Thread Kurt Young
+1 to disable, we also need to highlight this in 1.10 release notes. Best, Kurt On Fri, Nov 22, 2019 at 5:56 PM Zhenghua Gao wrote: > Hi, > > I wanted to bring up the discuss of Disable conversion between TIMESTAMP > and Long in parameters and results of UDXs. > > Since FLINK-12253[1]

[DISCUSS] Disable conversion between TIMESTAMP and Long in parameters and results of UDXs

2019-11-22 Thread Zhenghua Gao
Hi, I wanted to bring up the discuss of Disable conversion between TIMESTAMP and Long in parameters and results of UDXs. Since FLINK-12253[1] introduce the new TimestampType and conversion from and to long is not supported, the UDXs with Long parameters should not receive TIMESTAMP fields and