Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-10 Thread jincheng sun
Thank you for your positive feedback Seth ! Would you please vote in the voting mail thread. Thank you! Best, Jincheng Seth Wiesman 于2020年8月10日周一 下午10:34写道: > I think this sounds good. +1 > > On Wed, Aug 5, 2020 at 8:37 PM jincheng sun > wrote: > >> Hi David, Thank you for sharing the

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-10 Thread Seth Wiesman
I think this sounds good. +1 On Wed, Aug 5, 2020 at 8:37 PM jincheng sun wrote: > Hi David, Thank you for sharing the problems with the current document, > and I agree with you as I also got the same feedback from Chinese users. I > am often contacted by users to ask questions such as whether

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-05 Thread jincheng sun
Hi David, Thank you for sharing the problems with the current document, and I agree with you as I also got the same feedback from Chinese users. I am often contacted by users to ask questions such as whether PyFlink supports "Java UDF" and whether PyFlink supports "xxxConnector". The root cause of

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-05 Thread Wei Zhong
Hi Xingbo, Thanks for your information. I think the PySpark's documentation redesigning deserves our attention. It seems that the Spark community has also begun to treat the user experience of Python documentation more seriously. We can continue to pay attention to the discussion and

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-05 Thread Xingbo Huang
Hi, I found that the spark community is also working on redesigning pyspark documentation[1] recently. Maybe we can compare the difference between our document structure and its document structure. [1] https://issues.apache.org/jira/browse/SPARK-31851

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-04 Thread David Anderson
I'm delighted to see energy going into improving the documentation. With the current documentation, I get a lot of questions that I believe reflect two fundamental problems with what we currently provide: (1) We have a lot of contextual information in our heads about how Flink works, and we are

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-04 Thread jincheng sun
Hi Seth and David, I'm very happy to have your reply and suggestions. I would like to share my thoughts here: The main motivation we want to refactor the PyFlink doc is that we want to make sure that the Python users could find all they want starting from the PyFlink documentation mainpage.

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-03 Thread David Anderson
Jincheng, One thing that I like about the way that the documentation is currently organized is that it's relatively straightforward to compare the Python API with the Java and Scala versions. I'm concerned that if the PyFlink docs are more independent, it will be challenging to respond to

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-03 Thread Seth Wiesman
Hi Jincheng, I'm very excited to see the enthusiasm for documentation work but I am concerned about the communities long term ability to maintain this contribution. In particular, I'm concerned that this proposal duplicates a lot of content that will quickly get out of sync. So far the community

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-03 Thread jincheng sun
Would be great if you could join the contribution of PyFlink documentation @Marta ! Thanks for all of the positive feedback. I will start a formal vote then later... Best, Jincheng Shuiqiang Chen 于2020年8月3日周一 上午9:56写道: > Hi jincheng, > > Thanks for the discussion. +1 for the FLIP. > > A

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-08-02 Thread Shuiqiang Chen
Hi jincheng, Thanks for the discussion. +1 for the FLIP. A well-organized documentation will greatly improve the efficiency and experience for developers. Best, Shuiqiang Hequn Cheng 于2020年8月1日周六 上午8:42写道: > Hi Jincheng, > > Thanks a lot for raising the discussion. +1 for the FLIP. > > I

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-07-31 Thread Hequn Cheng
Hi Jincheng, Thanks a lot for raising the discussion. +1 for the FLIP. I think this will bring big benefits for the PyFlink users. Currently, the Python TableAPI document is hidden deeply under the TableAPI tab which makes it quite unreadable. Also, the PyFlink documentation is mixed with

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-07-31 Thread Marta Paes Moreira
Hi, Jincheng! Thanks for creating this detailed FLIP, it will make a big difference in the experience of Python developers using Flink. I'm interested in contributing to this work, so I'll reach out to you offline! Also, thanks for sharing some information on the adoption of PyFlink, it's great

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-07-30 Thread Xingbo Huang
Hi Jincheng, Thanks a lot for bringing up this discussion and the proposal. Big +1 for improving the structure of PyFlink doc. It will be very friendly to give PyFlink users a unified entrance to learn PyFlink documents. Best, Xingbo Dian Fu 于2020年7月31日周五 上午11:00写道: > Hi Jincheng, > >

Re: [DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-07-30 Thread Dian Fu
Hi Jincheng, Thanks a lot for bringing up this discussion and the proposal. +1 to improve the Python API doc. I have received many feedbacks from PyFlink beginners about the PyFlink doc, e.g. the materials are too few, the Python doc is mixed with the Java doc and it's not easy to find the

[DISCUSS] FLIP-133: Rework PyFlink Documentation

2020-07-30 Thread jincheng sun
Hi folks, Since the release of Flink 1.11, users of PyFlink have continued to grow. As far as I know there are many companies have used PyFlink for data analysis, operation and maintenance monitoring business has been put into production(Such as 聚美优品[1](Jumei), 浙江墨芷[2] (Mozhi) etc.). According