Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-19 Thread Ferenc Csaky
Hi, since there are no more comments for a while, if there are no more comments for another day, I will start a vote thread. Thanks, Ferenc On Thursday, March 14th, 2024 at 11:20, Ferenc Csaky wrote: > > > Hi, > > Gentle ping to see if there are any other concerns or things that seems

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-14 Thread Ferenc Csaky
Hi, Gentle ping to see if there are any other concerns or things that seems missing from the FLIP. Best, Ferenc On Monday, March 11th, 2024 at 11:11, Ferenc Csaky wrote: > > > Hi Jing, > > Thank you for your comments! Updated the FLIP with reasoning on the proposed > release versions

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-11 Thread Ferenc Csaky
Hi Jing, Thank you for your comments! Updated the FLIP with reasoning on the proposed release versions and included them in the headline "Release" field. Best, Ferenc On Sunday, March 10th, 2024 at 16:59, Jing Ge wrote: > > > Hi Ferenc, > > Thanks for the proposal! +1 for it! > >

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-10 Thread Jing Ge
Hi Ferenc, Thanks for the proposal! +1 for it! Similar to what Leonard mentioned. I would suggest: 1. Use the "release" to define the release version of the Kudu connector itself. 2. Optionally, add one more row underneath to describe which Flink versions this release will be compatible with,

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-10 Thread Yanquan Lv
Hi Ferenc, +1 for this FLIP. Ferenc Csaky 于2024年3月9日周六 01:49写道: > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > address them from earliest to latest. > > > How do you plan the review process in this case (e.g. incremental > over existing codebase or cumulative all at once) ? >

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-08 Thread Ferenc Csaky
Thank you Jeyhun, Leonard, and Hang for your comments! Let me address them from earliest to latest. > How do you plan the review process in this case (e.g. incremental over existing codebase or cumulative all at once) ? I think incremental would be less time consuming and complex for reviewers

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-08 Thread Hang Ruan
Hi, Ferenc. Thanks for the FLIP discussion. +1 for the proposal. I think that how to state this code originally lived in Bahir may be in the FLIP. Best, Hang Leonard Xu 于2024年3月7日周四 14:14写道: > Thanks Ferenc for kicking off this discussion, I left some comments here: > > (1) About the release

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-06 Thread Leonard Xu
Thanks Ferenc for kicking off this discussion, I left some comments here: (1) About the release version, could you specify kudu connector version instead of flink version 1.18 as external connector version is different with flink ? (2) About the connector config options, could you enumerate

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-06 Thread Jeyhun Karimov
Hi Ferenc, +1 for the FLIP. One minor comment. As part of the externalization process, the DataStream connector > implementation can be updated to the new Source/Sink APIs - How do you plan the review process in this case (e.g. incremental over existing codebase or cumulative all at once) ?

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-06 Thread Márton Balassi
Hi Feri, +1. Thanks for initiating this, the FLIP proposal looks good to me. On Wed, Mar 6, 2024 at 4:24 PM Ferenc Csaky wrote: > Hello devs, > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > connector, as recently > the Apache Bahir project were moved to the attic

[DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-06 Thread Ferenc Csaky
Hello devs, Opening this thread to discuss a FLIP [1] about externalizing the Kudu connector, as recently the Apache Bahir project were moved to the attic [2]. Some details were discussed already in another thread [3]. I am proposing to externalize this connector and keep it maintainable, and