Re: [DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-06-24 Thread Hequn Cheng
Hi Jark, Impressive document! I have gone over the document quickly and left some comments. I will have a detailed look later. Below are two main thoughts from my side: 1. In the TableSource interface, can we move the getBoundedness() method into the underneath Source? This brings some benefits

Re: [DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-06-24 Thread Jark Wu
Thanks Timo, I think it's fine to target it for Flink 1.10. Looking forward for your feedback. On Mon, 24 Jun 2019 at 15:07, Timo Walther wrote: > Thanks for working on this great design document Jark. I think having > well-defined terminilogy and semantics around tables, changelogs, table >

Re: [DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-06-24 Thread Timo Walther
Thanks for working on this great design document Jark. I think having well-defined terminilogy and semantics around tables, changelogs, table sources/sinks, and DDL should have been done much earlier. I will take a closer look at the concepts and give feedback soon. I think having those

Re: [DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-05-27 Thread Kurt Young
Thanks Jark for bringing this topic. I think proper concepts is very important for users who are using Table API & SQL. Especially for them to have a clear understanding about the behavior of the SQL job. Also this is essential for connector developers to have a better understanding why we

[DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-05-27 Thread Jark Wu
Hi all, We have prepared a design doc [1] about source and sink concepts in Flink SQL. This is actually an extended discussion about SQL DDL [2]. In the design doc, we want to figure out some concept problems. For examples: 1. How to define boundedness in DDL 2. How to define a changelog in