Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-27 Thread Timo Walther
Hi all, thanks for the great feedback! I see a clear majority for a new Java DSL. I agree with Dawid that we should aim for 1.9. Compared to other efforts, this is a relatively small change ;-) I will further develop my protoype and come back to you once I have a production-ready solution.

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-26 Thread Elias Saalmann
Hi all, I'm investigating using Table-API as an abstraction for Batch-API in our GRADOOP project [1]. As a user of Flink I like to give you some feedback from the user perspective. I really like Timo's ideas - since we built another framework which is based on Apache Flink we are just

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-26 Thread jincheng sun
Thanks for bringing up this DISCUSS Timo! Java Expression DSL is pretty useful for java user. When we have the Java Expression DSL, Java API will become very rich and easy to use! +1 from my side. Best, Jincheng Dawid Wysakowicz 于2019年3月26日周二 下午5:08写道: > Hi, > > I really like the idea of

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-26 Thread Dawid Wysakowicz
Hi, I really like the idea of introducing Java Expression DSL. I think this will solve many problems e.g. right now it's quite tricky how string literals work in scala (sometimes it might go through the ExpressionParser and it will end up as an UnresolvedFieldReference), another important problem

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-21 Thread Jark Wu
Hi Timo, Sounds good to me. Do you want to deprecate the string-based API in 1.9 or make the decision in 1.10 after some feedbacks ? On Thu, 21 Mar 2019 at 21:32, Timo Walther wrote: > Thanks for your feedback Rong and Jark. > > @Jark: Yes, you are right that the string-based API is used

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-21 Thread Timo Walther
Thanks for your feedback Rong and Jark. @Jark: Yes, you are right that the string-based API is used quite a lot. On the other side, the potential user base in the future is still bigger than our current user base. Because the Table API will become equally important as the DataStream API, we

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-20 Thread Jark Wu
Hi Timo, I'm +1 on the proposal. I like the idea to provide a Java DSL which is more friendly than string-based approach in programming. My concern is if/when we can drop the string-based expression parser. If it takes a very long time, we have to paid more development cost on the three Table

Re: [DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-19 Thread Rong Rong
Thanks for sharing the initiative of improving Java side Table expression DSL. I agree as in the doc stated that Java DSL was always a "3rd class citizen" and we've run into many hand holding scenarios with our Flink developers trying to get the Stringify syntax working. Overall I am a +1 on

[DISCUSS] Introduction of a Table API Java Expression DSL

2019-03-18 Thread Timo Walther
Hi everyone, some of you might have already noticed the JIRA issue that I opened recently [1] about introducing a proper Java expression DSL for the Table API. Instead of using string-based expressions, we should aim for a unified, maintainable, programmatic Java DSL. Some background: The