Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-18 Thread Alexander Alexandrov
Massive +1 for switching to space indention. Makes the code render consistently across various viewers (e.g. Github UI, Apache infrastructure, IDEs). 2015-03-18 1:29 GMT+01:00 Fabian Hueske fhue...@gmail.com: Touching every file of the code would also be a good opportunity to switch from tab

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-18 Thread Robert Metzger
I'm against changing the indentation, for the same reasons as Stephan listed. In my opinion, the codebase has grown too large to just switch the indentation or the entire code style (to the google style or whatever). We have 235870 LOC of Java and 24173 LOC of Scala. Therefore, I'm proposing to:

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-18 Thread Stephan Ewen
I agree, if we set p a new project, we should use space indentation. Should we really refactor 300k lines of code? Would be massive. Also: The history would basically show a single committer for all code. Git blame (for error tracing) would become useless. On Wed, Mar 18, 2015 at 3:49 PM,

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-18 Thread Henry Saputra
+1 for keeping the tabs vs space for now. When I start working on Flink I was itching to move to spaces indentation since that makes reader consistent. But that was the choice by preference made early on and I think we could keep it and add as exception in Java code style. Scala, on the other

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-17 Thread Fabian Hueske
Touching every file of the code would also be a good opportunity to switch from tab to space indention. So if we enforce a strict style, we could also address this issue which causes discussions every now and then. 2015-03-16 21:53 GMT+01:00 Aljoscha Krettek aljos...@apache.org: No, but I don't

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-16 Thread Maximilian Michels
+1 for enforcing a more strict Java code style. However, let's not introduce a line legth of 100 like in Scala. I think that's hurting readability of the code. On Sat, Mar 14, 2015 at 4:41 PM, Ufuk Celebi u...@apache.org wrote: On Saturday, March 14, 2015, Aljoscha Krettek aljos...@apache.org

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-16 Thread Alexander Alexandrov
+1 for not limiting the line length. 2015-03-16 14:39 GMT+01:00 Stephan Ewen se...@apache.org: +1 for not limiting the line length. Everyone should have a good sense to break lines. When in exceptional cases people violate this, it is usually for a good reason. On Mon, Mar 16, 2015 at 2:18

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-16 Thread Hermann Gábor
+1 for the stricter Java code styles. We should not forget about providing code formatter settings for Eclipse and Intellij IDEA (as mentioned above). That would help a lot. (Of course if we'll use Google Code Style, they already provide such files

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-16 Thread Till Rohrmann
Do we already enforce the official Scala style guide strictly? On Mon, Mar 16, 2015 at 4:57 PM, Aljoscha Krettek aljos...@apache.org wrote: I'm already always sticking to the official Scala style guide, with the exception of 100 line length. On Mar 16, 2015 3:27 PM, Till Rohrmann

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-16 Thread Aljoscha Krettek
I'm already always sticking to the official Scala style guide, with the exception of 100 line length. On Mar 16, 2015 3:27 PM, Till Rohrmann trohrm...@apache.org wrote: +1 for stricter Java code styles. I haven't looked into the Google Code Style but maybe we make it easier for new contributors

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-13 Thread Henry Saputra
Regarding style, yes, we already have them in place but they are very loose, especially in Java. I guess it is a no good deed goes unpunished scenario. To tighten up the style rules, for example following Google Java style with some documented exceptions, will require massive code changes. But we

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-13 Thread Henry Saputra
Agree. We have make decision either to play tight or loose on the code style and guide. Once the codebase is getting too large and more committers coming in then it would be too late. We can not have our cake and eat it too. Looking forward to what others think since I already have my 2-cents

Re: [DISCUSS] Issues with heterogeneity of the code

2015-03-09 Thread Ufuk Celebi
Hey Stephan, On 08 Mar 2015, at 23:17, Stephan Ewen se...@apache.org wrote: Hi everyone! I would like to start an open discussion about some issue with the heterogeneity of the Flink code base. Thanks for bringing this up. I agree with your position. The related discussion about using

[DISCUSS] Issues with heterogeneity of the code

2015-03-08 Thread Stephan Ewen
Hi everyone! I would like to start an open discussion about some issue with the heterogeneity of the Flink code base. We have, since the beginning in Apache (and even since we started the predecessor project, Stratosphere) refrained from strictly enforcing conventions like formatting, style, or