Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-10 Thread Leonard Xu
Hi, all I’m +1 to support HBase 2.x and also keep the HBase1.x in flink project. IIRC, HBase1.x is still widely used in production in the early discussion of this thread according to HBase PMC memeber Yu Li and OpenInx’s investigation. Moving HBase1.x connector to Bahir means the HBase1.x

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-10 Thread Márton Balassi
Hi All, I am also fairly torn on this one, however unless we are vigilant in keeping the flink repository relatively lean the number of modules will just keep increasing and pose an increasingly greater maintainability challenge. Less frequently used connectors are a strong candidate to be

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-10 Thread Robert Metzger
@Jark: Thanks for bringing up these concerns. All the problems you've mentioned are "solvable": - uber jar: Bahir could provide a hbase1 uber jar (we could theoretically also add a dependency from flink to bahir and provide the uber jar from Flink) - e2e tests: we know that the connector is

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-07 Thread Jark Wu
I'm +1 to add HBase 2.x However, I have some concerns about moving HBase 1.x to Bahir: 1) As discussed above, there are still lots of people using HBase 1.x. 2) Bahir doesn't have the infrastructure to run the existing HBase E2E tests. 3) We also paid lots of effort to provide an uber connector

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-07 Thread Robert Metzger
Hi, Thank you for picking this up so quickly. I have no objections regarding all the proposed items. @Gyula: Once the bahir contribution is properly reviewed, ping me if you need somebody to merge it. On Fri, Aug 7, 2020 at 10:43 AM Márton Balassi wrote: > Hi Robert and Gyula, > > Thanks for

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-07 Thread Márton Balassi
Hi Robert and Gyula, Thanks for reviving this thread. We have the implementation (currently for 2.2.3) and it is straightforward to contribute it back. Miklos (ccd) has recently written a readme for said version, he would be interested in contributing the upgraded connector back. The latest HBase

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-07 Thread Gyula Fóra
Hi Robert, I completely agree with you on the Bahir based approach. I am happy to help with the contribution on the bahir side, with thorough review and testing. Cheers, Gyula On Fri, 7 Aug 2020 at 09:30, Robert Metzger wrote: > It seems that this thead is not on dev@ anymore. Adding it

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-08-07 Thread Robert Metzger
It seems that this thead is not on dev@ anymore. Adding it back ... On Fri, Aug 7, 2020 at 9:23 AM Robert Metzger wrote: > I would like to revive this discussion. There's a new JIRA[1] + PR[2] for > adding HBase 2 support. > > it seems that there is demand for a HBase 2 connector, and consensus

Re:Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-06-19 Thread chaojianok
+1 to support HBase 2.x And I think the 1.4.x version can be retained for the time being, so that users who are currently using the 1.4.x version can have more time to evaluate whether their projects need to be upgraded and the cost of upgrading. At 2020-06-19 12:35:36, "Jark Wu"

Re: Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-06-19 Thread Gyula Fóra
Hi! Having both 1.4.x and 2.x supported means we need different modules or some shim logic as they are not compatible with each other. I would love to avoid this if possible because it is a lot of extra effort from a maintainability perspective. It would be great to see how many users still use

Re: [DISCUSS] Upgrade HBase connector to 2.2.x

2020-06-18 Thread Jark Wu
+1 to support HBase 2.x But not sure about dropping support for 1.4.x I cc'ed to user@ and user-zh@ to hear more feedback from users. Best, Jark On Thu, 18 Jun 2020 at 21:25, Gyula Fóra wrote: > Hi All! > > I would like to revive an old ticket >

[DISCUSS] Upgrade HBase connector to 2.2.x

2020-06-18 Thread Gyula Fóra
Hi All! I would like to revive an old ticket and discussion around upgrading the HBase version of the connector. The current HBase version is 1.4.3 which is over 2 years old at this point and incompatible with the newer HBase versions used at