Re: [Discuss] Upgrade JUnit to 4.12

2016-10-05 Thread Greg Hogan
Tests are passing with one additional change to an inner test class visibility. The ticket is FLINK-4740. On Wed, Oct 5, 2016 at 3:52 AM, Till Rohrmann wrote: > +1 for that :-) > > On Tue, Oct 4, 2016 at 10:11 PM, Greg Hogan wrote: > > > PowerMock

Re: [Discuss] Upgrade JUnit to 4.12

2016-10-05 Thread Till Rohrmann
+1 for that :-) On Tue, Oct 4, 2016 at 10:11 PM, Greg Hogan wrote: > PowerMock reports "org.powermock.reflect.exceptions. > FieldNotFoundException: > Field 'fTestClass' was not found in class > org.junit.internal.runners.MethodValidator." >

Re: [Discuss] Upgrade JUnit to 4.12

2016-10-04 Thread Greg Hogan
PowerMock reports "org.powermock.reflect.exceptions.FieldNotFoundException: Field 'fTestClass' was not found in class org.junit.internal.runners.MethodValidator." https://github.com/jayway/powermock/issues/551 This is fixed in PowerMock 1.6.1+ (currently using 1.5.5, latest is 1.6.5):

Re: [Discuss] Upgrade JUnit to 4.12

2016-10-04 Thread Stephan Ewen
>From my side +1, unless there are known issues with JUnit 4.12 On Tue, Oct 4, 2016 at 9:07 PM, Greg Hogan wrote: > JUnit 4.12 was released 4 Dec 2014. Flink is currently using JUnit 4.11 > from 14 Nov 2012. > https://github.com/junit-team/junit4/releases > > My use case

[Discuss] Upgrade JUnit to 4.12

2016-10-04 Thread Greg Hogan
JUnit 4.12 was released 4 Dec 2014. Flink is currently using JUnit 4.11 from 14 Nov 2012. https://github.com/junit-team/junit4/releases My use case is the support for assert equals on boolean arrays, but in general this looks to be an innocuous change and I could not find any prior discussion.