Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-17 Thread Stephan Ewen
@Greg - One benefit I can clearly see is the following: If we keep that old 1.1-style state code, than we want to guarantee its correctness in the face of the changes that have been made (consolidate state code to be per-operator rather than per-task in the runtime as well) and the changes that

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-17 Thread Stefan Richter
I think we are still doing changes for which this is relevant. Also I cannot really see a benefit in delaying this because the whole discussion will apply in exactly the same way to 1.5. > Am 17.08.2017 um 13:29 schrieb Greg Hogan : > > There’s an argument for delaying this

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-17 Thread Greg Hogan
There’s an argument for delaying this change to 1.5 since the feature freeze is two weeks away. There is little time to realize benefits from removing this code. "The reason for that is that there is a lot of code mapping between the completely different legacy format (1.1.x, not re-scalable)

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-17 Thread Stefan Richter
One more comment about the consequences of this PR, as pointed out in the comments on Github: this will also break direct compatibility for the CEP library between Flink 1.2 and 1.4. There is still a way to migrate via Flink 1.3: Flink 1.1/2 -> savepoint -> Flink 1.3 -> savepoint -> Flink 1.4.

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-16 Thread Stefan Richter
Hi, after there have been no objections since a long time, I took the next step and created a PR that implements this change in commit 95e44099784c9deaf2ca422b8dfc11c3d67d7f82 of https://github.com/apache/flink/pull/4550 . Announcing this here as a

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-02 Thread Kostas Kloudas
+1 > On Aug 2, 2017, at 3:16 PM, Till Rohrmann wrote: > > +1 > > On Wed, Aug 2, 2017 at 9:12 AM, Stefan Richter > wrote: > >> +1 >> >> Am 28.07.2017 um 16:03 schrieb Stephan Ewen : >> >> Seems like no one raised a concern

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-02 Thread Till Rohrmann
+1 On Wed, Aug 2, 2017 at 9:12 AM, Stefan Richter wrote: > +1 > > Am 28.07.2017 um 16:03 schrieb Stephan Ewen : > > Seems like no one raised a concern so far about dropping the savepoint > format compatibility for 1.1 in 1.4. > > Leaving this

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-08-02 Thread Stefan Richter
+1 > Am 28.07.2017 um 16:03 schrieb Stephan Ewen : > > Seems like no one raised a concern so far about dropping the savepoint format > compatibility for 1.1 in 1.4. > > Leaving this thread open for some more days, but from the sentiment, it seems > like we should go ahead? >

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-07-28 Thread Ufuk Celebi
On Fri, Jul 28, 2017 at 4:03 PM, Stephan Ewen wrote: > Seems like no one raised a concern so far about dropping the savepoint > format compatibility for 1.1 in 1.4. > > Leaving this thread open for some more days, but from the sentiment, it > seems like we should go ahead? +1

Re: [POLL] Dropping savepoint format compatibility for 1.1.x in the Flink 1.4.0 release

2017-07-28 Thread Stephan Ewen
Seems like no one raised a concern so far about dropping the savepoint format compatibility for 1.1 in 1.4. Leaving this thread open for some more days, but from the sentiment, it seems like we should go ahead? On Wed, Jul 12, 2017 at 4:43 PM, Stephan Ewen wrote: > Hi users!