Re: [VOTE] Release 1.5.0, release candidate #5

Thanks for reporting the issues Timo. I think both of them are not blocking the release and should be addressed for the following releases. Cheers, Till On Thu, May 24, 2018 at 10:52 AM, Timo Walther wrote: > I tried to build the relase locally but 3 tests failed. 2 are

Re: [VOTE] Release 1.5.0, release candidate #5

I tried to build the relase locally but 3 tests failed. 2 are related to the evironment in which the tests are executed (see [1]) and the other should have been caught by Travis which did not happen (see last comments in [2]). [1] https://issues.apache.org/jira/browse/FLINK-9424 [2]

Re: [VOTE] Release 1.5.0, release candidate #5

-1 Piotr just found a race condition between the TM registration at the RM and slot requests coming from the SlotManager/RM [1]. This is a release blocker since it affects all deployments. Consequently I have to cancel this RC :-( [1] https://issues.apache.org/jira/browse/FLINK-9427 On Wed, May

Re: [VOTE] Release 1.5.0, release candidate #5

+1 (non-binding) I have run all examples (batch & streaming), and only found a non-blocking issue with TPCHQuery3 [1] which has been introduced a year ago. I have also deployed a cluster with HA enabled on YARN (Hadoop 2.8.3) without problems. [1]

Re: [VOTE] Release 1.5.0, release candidate #5

+1 Checked signatures Ran test suite Due to FLINK-9340 and FLINK-9091, I had to run tests in multiple rounds. Cheers On Wed, May 23, 2018 at 7:39 AM, Fabian Hueske wrote: > +1 (binding) > > - checked hashes and signatures > - checked source archive and didn't find

Re: [VOTE] Release 1.5.0, release candidate #5

+1 (binding) - checked hashes and signatures - checked source archive and didn't find unexpected binary files - built from source archive skipping the tests (mvn -DskipTests clean install), started a local cluster, and ran an example program. Thanks, Fabian 2018-05-23 15:39 GMT+02:00 Till

Re: [VOTE] Release 1.5.0, release candidate #5

Fabian pointed me to the updated ASF release policy [1] and the changes it implies for the checksum files. New releases should no longer provide a MD5 checksum file and the sha checksum file should have a proper file name extension `sha512` instead of `sha`. I've updated the release artifacts [2]

Re: [VOTE] Release 1.5.0, release candidate #5

+1 from me. Additionally for this RC5 I did some manual tests to double check backward compatibility of the bug fix: https://issues.apache.org/jira/browse/FLINK-9295 The issue with this bug fix was that it was merged after 1.5.0 RC4 but just

Re: [VOTE] Release 1.5.0, release candidate #5

Thanks for the pointer Sihua, I've properly closed FLINK-9070. On Wed, May 23, 2018 at 4:49 AM, sihua zhou wrote: > > Hi, > just one minor thing, I found the JIRA release notes seem a bit > inconsistent with the this RC. For example, https://issues.apache.org/ >

Re: [VOTE] Release 1.5.0, release candidate #5

We need to triage our Jira issues before the release: Issues that are actually merged/fixed should be marked as done and have 1.5.0 as fixVersion, all issues that are not closed/done/fixed should not have 1.5.0 as release version. I.e. there should be no open issues with 1.5.0 as fixVersion,

Re:[VOTE] Release 1.5.0, release candidate #5

Hi, just one minor thing, I found the JIRA release notes seem a bit inconsistent with the this RC. For example, https://issues.apache.org/jira/browse/FLINK-9058 hasn't been merged yet but included in the release notes, and https://issues.apache.org/jira/browse/FLINK-9070 has been merged but

[VOTE] Release 1.5.0, release candidate #5

Hi everyone, Please review and vote on the release candidate #5 for the version 1.5.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],