Re: [CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread jincheng sun
Hi all, When we did the Window Interface work in FLIP32, we found `OverWindow` and `Window` are confusing in the API. It is mentioned that we want to rename it to `GroupWindow` many times. So, here just a suggestion, how about deprecated the `Window` in release-1.8, and remove the `Window` in

Re: [CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Tzu-Li (Gordon) Tai
Hi Fokko, I've looked at FLINK-11911 (Make KafkaTopicPartition a POJO), and left a comment in the PR. Main gist is that this change would break state compatibility for previous versions of the FlinkKafkaConsumers, since changing that behind the scenes Flink would use different serializers for

Re: [CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Aljoscha Krettek
@Robert I was planning to do that, yes! :-) > On 13. Mar 2019, at 13:04, Robert Metzger wrote: > > Aljoscha, can you CC the user@ list on the next RC, so that a wider > audience of people sees it and can help testing with their prod jobs? > > On Wed, Mar 13, 2019 at 12:47 PM jincheng sun >

Re: [CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Robert Metzger
Aljoscha, can you CC the user@ list on the next RC, so that a wider audience of people sees it and can help testing with their prod jobs? On Wed, Mar 13, 2019 at 12:47 PM jincheng sun wrote: > Thanks for prepare the new RC. Aljoscha! > > I also merged the FLINK-11892 >

Re: [CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread jincheng sun
Thanks for prepare the new RC. Aljoscha! I also merged the FLINK-11892 (end-to-end test doc improve) into release-1.8 branch, and thanks for the quick fix @Yu. Looking forward to the new RC. Best, Jincheng Aljoscha Krettek 于2019年3月13日周三

[CANCEL][VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Aljoscha Krettek
Hi, I’m hereby canceling the vote for RC1 of Flink 1.8.0 because of the aforementioned issues. I’ll create a new RC as soon as those issues are resolved. Best, Aljoscha > On 13. Mar 2019, at 12:24, Aljoscha Krettek wrote: > > Hi, > > Thanks for the verification performed so far. It seems I

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Aljoscha Krettek
Hi, Thanks for the verification performed so far. It seems I have to cancel this vote and create a new RC. I’ll wait for - https://issues.apache.org/jira/browse/FLINK-11901 to be resolved. There have also been two blockers that are now

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-13 Thread Timo Walther
I just found https://issues.apache.org/jira/browse/FLINK-11901 According to Chesnay, this is a release blocker. Regards, Timo Am 13.03.19 um 09:48 schrieb Driesprong, Fokko: -1 (non-binding) I'd like to see both get into Flink 1.8: https://github.com/apache/flink/pull/7547

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-12 Thread jincheng sun
I agree with @Robert Metzger 's suggestion! The 1.8 version is a big release, we have a lot of enhancements, and letting users participate in the test is very helpful for the quality of the release. BTW: I am also doing RC verification, but I haven't fully verified it yet, And I have already

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-12 Thread Robert Metzger
I'm wondering whether we should tweet about this release candidate, and also post on the user@ mailing list to ask for some help with testing the RC in production environments? On Tue, Mar 12, 2019 at 11:23 AM Kurt Young wrote: > +1 (non-binding) > > Checked items: > - checked checksums and

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-12 Thread Kurt Young
+1 (non-binding) Checked items: - checked checksums and GPG files - verified that the source archives do not contains any binaries - checked that all POM files point to the same version - build from source Best, Kurt On Tue, Mar 12, 2019 at 9:20 AM Congxian Qiu wrote: > +1 (non-binding) > >

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-11 Thread Congxian Qiu
+1 (non-binding) Checked items: - run mvn clean install locally with success - run program on yarn, success - test state schema evolution(POJO state type) with the following paths success(heap)  - 1.6 -> 1.8 -> 1.8  - 1.7 -> 1.8 -> 1.8  - 1.8 -> 1.8 Best, Congxian On Mar 11, 2019, 21:07 +0800,

Re: [VOTE] Release 1.8.0, release candidate #1

2019-03-11 Thread Stephan Ewen
Thank you, Aljoscha, for preparing the release candidate. Here is the (newly updated) guide on how to verify a release: https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Release Best, Stephan On Mon, Mar 11, 2019 at 2:07 PM Aljoscha Krettek wrote: > Hi everyone, > Please

[VOTE] Release 1.8.0, release candidate #1

2019-03-11 Thread Aljoscha Krettek
Hi everyone, Please review and vote on the release candidate 1 for Flink 1.8.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the