Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-12 Thread Tzu-Li (Gordon) Tai
RC2 (for Flink 1.17.0) vote has started in a separate thread: https://lists.apache.org/thread/mff76c2hzcb1mk8fm5m2h4z0j73qz2vk Please test and cast your votes! On Tue, Apr 11, 2023 at 11:45 AM Martijn Visser wrote: > +1, thanks for driving this Gordon. > > On Tue, Apr 11, 2023 at 8:15 PM

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-11 Thread Martijn Visser
+1, thanks for driving this Gordon. On Tue, Apr 11, 2023 at 8:15 PM Tzu-Li (Gordon) Tai wrote: > Hi all, > > Martijn and I discussed offline to cancel this vote. > > Moreover, now that Flink 1.17 is out and we still haven't released > anything yet for the newly externalized Kafka connector,

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-11 Thread Tzu-Li (Gordon) Tai
Hi all, Martijn and I discussed offline to cancel this vote. Moreover, now that Flink 1.17 is out and we still haven't released anything yet for the newly externalized Kafka connector, we've decided to skip releasing a version that matches with Flink 1.16 all together, and instead go straight to

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-05 Thread Mason Chen
+1 for new RC! Best, Mason On Tue, Apr 4, 2023 at 11:32 AM Tzu-Li (Gordon) Tai wrote: > Hi all, > > I've ported the critical fixes I mentioned to v3.0 and v4.0 branches of > apache/flink-connector-kafka now. > > @martijnvis...@apache.org let me know if you'd > need help with creating a new

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-04 Thread Tzu-Li (Gordon) Tai
Hi all, I've ported the critical fixes I mentioned to v3.0 and v4.0 branches of apache/flink-connector-kafka now. @martijnvis...@apache.org let me know if you'd need help with creating a new RC, if there's too much to juggle on your end. Happy to help out. Thanks, Gordon On Sun, Apr 2, 2023

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-03 Thread Konstantin Knauf
+1. Thanks, Gordon! Am Mo., 3. Apr. 2023 um 06:37 Uhr schrieb Tzu-Li (Gordon) Tai < tzuli...@apache.org>: > Hi Martijn, > > Since this RC vote was opened, we had three critical bug fixes that was > merged for the Kafka connector: > >- https://issues.apache.org/jira/browse/FLINK-31363 >-

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-04-02 Thread Tzu-Li (Gordon) Tai
Hi Martijn, Since this RC vote was opened, we had three critical bug fixes that was merged for the Kafka connector: - https://issues.apache.org/jira/browse/FLINK-31363 - https://issues.apache.org/jira/browse/FLINK-31305 - https://issues.apache.org/jira/browse/FLINK-31620 Given the

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-02-09 Thread Tzu-Li (Gordon) Tai
+1 (binding) - Verified legals (license headers and root LICENSE / NOTICE file). AFAICT no dependencies require explicit acknowledgement in the NOTICE files. - No binaries in staging area - Built source with tests - Verified signatures and hashes - Web PR changes LGTM Thanks Martijn! Cheers,

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-02-06 Thread Mason Chen
That makes sense, thanks for the clarification! Best, Mason On Wed, Feb 1, 2023 at 7:16 AM Martijn Visser wrote: > Hi Mason, > > Thanks, [4] is indeed a copy-paste error and you've made the right > assumption that > >

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-02-01 Thread Martijn Visser
Hi Mason, Thanks, [4] is indeed a copy-paste error and you've made the right assumption that https://repository.apache.org/content/repositories/orgapacheflink-1582/org/apache/flink/ is the correct maven central link. I think we should use FLINK-30052 to move the Kafka connector code from the

Re: [VOTE] Release flink-connector-kafka, release candidate #1

2023-02-01 Thread Mason Chen
+1 (non-binding) * Verified hashes and signatures * Verified no binaries * Verified LICENSE and NOTICE files * Verified poms point to 3.0.0-1.16 * Reviewed web PR * Built from source * Verified git tag I think [4] your is a copy-paste error and I did all the verification assuming that

[VOTE] Release flink-connector-kafka, release candidate #1

2023-01-31 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #1 for flink-connector-kafka version 3.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Note: this is the same code as the Kafka connector for the Flink 1.16 release.