Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-28 Thread Bowen Li
Hi all, I want to give an update from my perspective. flink-connector-kinesis' two critical dependencies KPL and Dynamo stream adapter haven't been converted to Apache 2.0 license yet. The license-changing PRs [1] are still pending, for ~2 months so far. I've left comments there, and hope they

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-18 Thread Dyana Rose
I've pushed an early WIP of the code changes to our fork and added a long comment on the work that's been done, what issues I've come across, and requests for discussion on those issues https://issues.apache.org/jira/browse/FLINK-12847 Thanks, Dyana On Fri, 14 Jun 2019 at 10:34, Aljoscha

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-14 Thread Aljoscha Krettek
+1 Nice! Less special-case handling is always good. > On 14. Jun 2019, at 10:30, Thomas Weise wrote: > > Dyana, thanks for taking this up! > > The flink-connector-kinesis module is already part of the CI pipeline, it > is just excluded when creating the release. So what needs to be done is to

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-14 Thread Thomas Weise
Dyana, thanks for taking this up! The flink-connector-kinesis module is already part of the CI pipeline, it is just excluded when creating the release. So what needs to be done is to remove the -Pinclude-kinesis cruft and make it part of the default modules instead. Thomas On Fri, Jun 14, 2019

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-14 Thread Dyana Rose
Brilliant. That Issue is in now under: https://issues.apache.org/jira/browse/FLINK-12847 Thanks, Dyana On Fri, 14 Jun 2019 at 03:07, Tzu-Li (Gordon) Tai wrote: > Hi, > > Thanks Dyana for bringing this up and Bowen for helping to move this > forward. Very happy to hear about this! > > Please

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-13 Thread Tzu-Li (Gordon) Tai
Hi, Thanks Dyana for bringing this up and Bowen for helping to move this forward. Very happy to hear about this! Please feel free to to create a new JIRA ticket for this and assign it to yourself. +1 to aim this for 1.9.0. The subtasks that Bowen mentioned looks good to me. Issues such as [1]

Re: Updating Kinesis Connector to latest Apache licensed libs

2019-06-13 Thread Bowen Li
Hi Dyana, Thanks for bringing this up! You are right that ASL is the blocker for us to officially include flink-connecotr-kinesis as a connector module to build and publish to Maven central. I've been thru the mess of building, publishing, and maintaining flink-connector-kinesis via Jfrog, and

Updating Kinesis Connector to latest Apache licensed libs

2019-06-13 Thread dyana . rose
The Kinesis Client Library v2.x and the AWS Java SDK v2.x both are now on the Apache 2.0 license. https://github.com/awslabs/amazon-kinesis-client/blob/master/LICENSE.txt https://github.com/aws/aws-sdk-java-v2/blob/master/LICENSE.txt There is a PR for the Kinesis Producer Library to update it