Re: primitiveDefaultValue in CodeGenUtils in Table API

2016-06-29 Thread Cody Innowhere
uni 2016 10:06 > *An: *dev@flink.apache.org > *Betreff: *Re: primitiveDefaultValue in CodeGenUtils in Table API > > > > @Fabian, > > given the example that a user wants to sum a column whose value might be > > null, with null check enabled. In this case, when the column value is null, >

AW: primitiveDefaultValue in CodeGenUtils in Table API

2016-06-29 Thread Fabian Hueske
Hi Cody, Aggregations are currently not performed by code-generated user functions. This would be a good improvement though. Check the DataSetAggregate class to learn how aggregations are translated into Flink Dataset programs. Best, Fabian Von: Cody Innowhere

Re: primitiveDefaultValue in CodeGenUtils in Table API

2016-06-29 Thread Cody Innowhere
@Fabian, given the example that a user wants to sum a column whose value might be null, with null check enabled. In this case, when the column value is null, -1 is set instead? Am I understanding correctly? On Wed, Jun 29, 2016 at 3:28 PM, Timo Walther wrote: > Hi Cody, > > default values are n

Re: primitiveDefaultValue in CodeGenUtils in Table API

2016-06-29 Thread Timo Walther
Hi Cody, default values are needed in cases where NULL values are not supported. This happens if the null check is disabled in TableConfig for efficiency reasons. Using 0 to DataType.MAX_VALUE for numeric types and -1 as a NULL equivalent in special cases seems more reasonable to me. Hope th

primitiveDefaultValue in CodeGenUtils in Table API

2016-06-28 Thread Cody Innowhere
Hi guys, I found that in CodeGenUtils, default values of numeric primitive types are set to -1, what's the consideration of setting the default values to -1 instead of 0? IMHO 0 would make more sense, although in DB if a field is null then all operations on this field will return null anyway.