Review Request: FLUME-1604. Check available disk space before throwing LogFileRetryableIOException.

2012-09-22 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7216/ --- Review request for Flume. Description --- Check if at least 1.5 times the

[jira] [Updated] (FLUME-1604) File Channel can create numerous files without actually writing anything to the files if the disk is full.

2012-09-22 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-1604: Attachment: (was: FLUME-1604.patch) File Channel can create numerous files

Re: Review Request: FLUME-1604. Check available disk space before throwing LogFileRetryableIOException.

2012-09-22 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7216/ --- (Updated Sept. 22, 2012, 6:36 a.m.) Review request for Flume. Changes ---

Re: Review Request: FLUME-1590: ExecSource doesn't kill it's child when shutting down

2012-09-22 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7167/#review11809 --- Brock, I don't see anything wrong with the patch except some

Re: Review Request: FLUME-1590: ExecSource doesn't kill it's child when shutting down

2012-09-22 Thread Hari Shreedharan
On Sept. 22, 2012, 7:04 a.m., Hari Shreedharan wrote: Brock, I don't see anything wrong with the patch except some unneeded whitespace changes in files which don't have any changes at all. But what I am trying to understand is the problem this is trying to solve. In the current

Re: Review Request: FLUME-1590: ExecSource doesn't kill it's child when shutting down

2012-09-22 Thread Brock Noland
On Sept. 22, 2012, 7:04 a.m., Hari Shreedharan wrote: Brock, I don't see anything wrong with the patch except some unneeded whitespace changes in files which don't have any changes at all. But what I am trying to understand is the problem this is trying to solve. In the current

Re: Review Request: FLUME-1593: FileChannel race condition when log file rolls

2012-09-22 Thread Brock Noland
On Sept. 21, 2012, 7:42 p.m., Brock Noland wrote: Thinking about this more, I think we should put some kind of limit on how fast we roll due to an exception. If the file system was full, it looks we'd end up creating a lot of log-* files which could cause us to run out of file ids

[jira] [Commented] (FLUME-1603) FileChannel capacity reached message is unclear

2012-09-22 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461138#comment-13461138 ] Brock Noland commented on FLUME-1603: - Good error message: The channel has reached

[jira] [Commented] (FLUME-1593) FileChannel race condition when log file rolls

2012-09-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461307#comment-13461307 ] Hudson commented on FLUME-1593: --- Integrated in flume-trunk #308 (See