Re: [DISCUSS] Test on Patch Available

2012-12-20 Thread Jarek Jarcec Cecho
Awesome, thank you very much Brock! Jarcec On Dec 19, 2012, at 10:38 PM, Brock Noland br...@cloudera.com wrote: Just an update here, the last two comments on this JIRA https://issues.apache.org/jira/browse/FLUME-1787 are the messages on failure and success. At present the only check it does

Re: [DISCUSS] Test on Patch Available

2012-12-20 Thread Brock Noland
Alright, I have the patch up here: https://issues.apache.org/jira/browse/FLUME-1787 Once it's committed I can do the final testing and modifications to our pre-commit build (https://builds.apache.org/job/PreCommit-FLUME-Build/) and we can turn this sucker on. Also, once we have the kinks worked

Re: [DISCUSS] Test on Patch Available

2012-12-19 Thread Brock Noland
Just an update here, the last two comments on this JIRA https://issues.apache.org/jira/browse/FLUME-1787 are the messages on failure and success. At present the only check it does is apply the patch and run the tests. We can add more checks over time. I ended up not using the Hadoop script

Re: [DISCUSS] Test on Patch Available

2012-12-08 Thread Mike Percy
I really like the idea of doing this! +1 from me if we can swing it. Regards, Mike On Fri, Dec 7, 2012 at 3:20 PM, Jarek Jarcec Cecho jar...@apache.orgwrote: Btw I just found very interesting draft that is explaining quite huge portions of the design:

[DISCUSS] Test on Patch Available

2012-12-07 Thread Brock Noland
Hi, I like how in the Hadoop project if you mark a patch Patch Available jenkins applies the patch to trunk, runs the tests, and outputs the result to the JIRA. Here is one example: http://s.apache.org/qz I think we should still run tests manually before commit. However, this will often give a

Re: [DISCUSS] Test on Patch Available

2012-12-07 Thread Brock Noland
Hi, Great to hear you were thinking the same thing! I have found the script they use to do the checking: https://github.com/apache/hadoop-common/blob/trunk/dev-support/test-patch.sh and I think we could probably implement something similar. I agree that our build machines are much busier so I