Re: [GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-09 Thread Ferenc Szabo
Hi Donat, ok Thanks, Ferenc On Sat, 9 Feb 2019 at 15:09, Bessenyei Balázs Donát wrote: > Hi Ferenc, > > It seems to me that you have force-pushed a commit removal to the branch. > In the future, please refrain from rewriting history (see >

Re: [GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-09 Thread Bessenyei Balázs Donát
Hi Ferenc, It seems to me that you have force-pushed a commit removal to the branch. In the future, please refrain from rewriting history (see https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History , https://git1-us-west.apache.org/docs/switching-to-git.html and

Re: [GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-08 Thread Bessenyei Balázs Donát
Awesome! Thank you, Ferenc. Donat On Fri, Feb 8, 2019, 10:43 Ferenc Szabo Hi Donat, > > thank you for pointing it out. I did not realize that the PR was not opened > to trunk. > I will fix it. > > Ferenc > > On Fri, Feb 8, 2019 at 7:32 AM Bessenyei Balázs Donát > wrote: > > > Hi Ferenc

Re: [GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-08 Thread Ferenc Szabo
Hi Donat, thank you for pointing it out. I did not realize that the PR was not opened to trunk. I will fix it. Ferenc On Fri, Feb 8, 2019 at 7:32 AM Bessenyei Balázs Donát wrote: > Hi Ferenc Szabó, > > Are you sure flume-1.8 is the right branch for this change? I think > this change should be

Re: [GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-07 Thread Bessenyei Balázs Donát
Hi Ferenc Szabó, Are you sure flume-1.8 is the right branch for this change? I think this change should be reverted and the commit cherry-picked to master. What do you think? Donat On Thu, Feb 7, 2019 at 11:21 PM GitBox wrote: > > szaboferee merged pull request #273: FLUME-3311 Update User

[GitHub] szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink

2019-02-07 Thread GitBox
szaboferee merged pull request #273: FLUME-3311 Update User Guide In HDFS Sink URL: https://github.com/apache/flume/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on