Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-10 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/#review152027 --- Ship it! Ship It! - Mike Percy On Oct. 10, 2016, 1:53 a.m.,

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-10 Thread Tristan Stevens
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/ --- (Updated Oct. 10, 2016, 8:53 a.m.) Review request for Flume and Grant Henke.

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-10 Thread Tristan Stevens
> On Oct. 7, 2016, 3:38 p.m., Attila Simon wrote: > > Patch applies clearly on trunk currently (probably will conflicts after > > FLUME-2971). Code compiles with "mvn clean install -DskipTests", site > > builds without error message on the generated html. When running tests I > > got errors

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-10 Thread Tristan Stevens
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/ --- (Updated Oct. 10, 2016, 8:49 a.m.) Review request for Flume and Grant Henke.

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-09 Thread Mike Percy
> On Oct. 9, 2016, 11:52 a.m., Mike Percy wrote: > > Looking pretty good. > > > > First of all, I had to make some changes to compile this. See below. > > > > Also, please fix the checkstyle errors. > > > > You can run it with the following command: $ mvn clean install -DskipTests > > > >

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-09 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/#review151939 --- Looking pretty good. First of all, I had to make some changes to

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-08 Thread Tristan Stevens
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/ --- (Updated Oct. 8, 2016, 9:41 p.m.) Review request for Flume and Grant Henke.

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-07 Thread Tristan Stevens
> On Oct. 7, 2016, 2:25 p.m., Mike Percy wrote: > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java, > > line 214 > > > > > > nit: missing space after comma. Did you run

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-07 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/#review151794 --- Patch applies clearly on trunk currently (probably will conflicts

Re: Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-07 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/#review151795 ---

Review Request 52598: FLUME-2999 - Kafka channel and sink should enable statically assigned partition per event via header

2016-10-06 Thread Tristan Stevens
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52598/ --- Review request for Flume. Repository: flume-git Description --- This