mr1716 opened a new pull request, #381:
URL: https://github.com/apache/flume/pull/381
This will update the version of protobuf and Guava to more recent versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
tmgstevens commented on PR #381:
URL: https://github.com/apache/flume/pull/381#issuecomment-1225829068
@mr1716 I'd avoided doing the protobuf one because I was worried about
backwards compatibility - do you think this is a safe change?
--
This is an automated message from the Apache Git S
tmgstevens commented on PR #380:
URL: https://github.com/apache/flume/pull/380#issuecomment-1225830492
@hboutemy please can you explain what you mean about reproducibile builds?
No issues necessarily, just checking what problem we are solving.
--
This is an automated message from the Apac
tmgstevens commented on code in PR #371:
URL: https://github.com/apache/flume/pull/371#discussion_r953902532
##
flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/TestUtil.java:
##
@@ -39,6 +39,9 @@ Licensed to the Apache Software Foundation (ASF)
tmgstevens commented on code in PR #371:
URL: https://github.com/apache/flume/pull/371#discussion_r953904225
##
flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java:
##
@@ -74,20 +74,8 @@
import java.util.Properties;
import java.
tmgstevens commented on PR #371:
URL: https://github.com/apache/flume/pull/371#issuecomment-1225846395
Thinking this through, the current behaviour is that hostname checking is
enabled, since we're using the Kafka 2.0 client already. So if we were to
approve this change we'd be adding in a
tmgstevens commented on PR #359:
URL: https://github.com/apache/flume/pull/359#issuecomment-1225847124
@rgoers do we think this is already resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mr1716 commented on PR #381:
URL: https://github.com/apache/flume/pull/381#issuecomment-1225849974
@tmgstevens I think it's a safe change because it makes the tool more
secure/safe for the end user.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mr1716 closed pull request #381: Upgrade Protobuf and Guava
URL: https://github.com/apache/flume/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
mr1716 commented on PR #381:
URL: https://github.com/apache/flume/pull/381#issuecomment-1225859844
But if protobuf wont be upgraded for backwards compatibility, that makes
sense. Will close it then
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
geniusjoe commented on PR #371:
URL: https://github.com/apache/flume/pull/371#issuecomment-1225880720
> Thinking this through, the current behaviour is that hostname checking is
enabled, since we're using the Kafka 2.0 client already. So if we were to
approve this change we'd be
rgoers commented on PR #359:
URL: https://github.com/apache/flume/pull/359#issuecomment-1226053542
@tmgstevens Yes, I believe this was fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
12 matches
Mail list logo
