[GitHub] [flume] busbey commented on pull request #409: add year 2023 to Notice files

2023-06-05 Thread via GitHub
busbey commented on PR #409: URL: https://github.com/apache/flume/pull/409#issuecomment-1577028193 I'm -0 on switching to use "Present". At least my reading of [the published ASF policy on NOTICE files](https://www.apache.org/legal/src-headers.html#notice) requires actual years.

[GitHub] [flume] nikita15p opened a new pull request, #411: [FLUME-3473] fixed testMinimumRequiredSpaceTooSmallforPut test by changing buffer size dynamic

2023-05-21 Thread via GitHub
nikita15p opened a new pull request, #411: URL: https://github.com/apache/flume/pull/411 Current state: Since the buffer size is limited by the size ``` byte[] buffer = new byte[64 * 1024]; ``` This was causing while loop to execute limited by buffer size. This was causing

[GitHub] [flume] nikita15p commented on pull request #405: [FLUME-3468] fix default value of passwordFile property when userName is set for jms source

2023-06-11 Thread via GitHub
nikita15p commented on PR #405: URL: https://github.com/apache/flume/pull/405#issuecomment-1586554737 @rgoers can u please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flume] nikita15p commented on pull request #411: [FLUME-3473] fixed testMinimumRequiredSpaceTooSmallforPut test by changing buffer size dynamic

2023-07-30 Thread via GitHub
nikita15p commented on PR #411: URL: https://github.com/apache/flume/pull/411#issuecomment-1657442355 @rgoers please review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flume] rgoers commented on pull request #286: FLUME-3216.Avoid reading content repeatedly.

2023-08-10 Thread via GitHub
rgoers commented on PR #286: URL: https://github.com/apache/flume/pull/286#issuecomment-1673457500 I am wondering why this was closed? Is the fix not valid. It would have been nice to have a test to validate this. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flume] highfei2011 closed pull request #286: FLUME-3216.Avoid reading content repeatedly.

2023-08-08 Thread via GitHub
highfei2011 closed pull request #286: FLUME-3216.Avoid reading content repeatedly. URL: https://github.com/apache/flume/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flume] whitelilis closed pull request #62: bugfix: when log rotate, taildir source will treat it as new file, so…

2023-06-28 Thread via GitHub
whitelilis closed pull request #62: bugfix: when log rotate, taildir source will treat it as new file, so… URL: https://github.com/apache/flume/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flume] dependabot[bot] opened a new pull request, #416: Bump snappy-java from 1.1.8.4 to 1.1.10.1 in /flume-parent

2023-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #416: URL: https://github.com/apache/flume/pull/416 Bumps [snappy-java](https://github.com/xerial/snappy-java) from 1.1.8.4 to 1.1.10.1. Release notes Sourced from https://github.com/xerial/snappy-java/releases;>snappy-java's releases.

[GitHub] [flume] nikita15p commented on pull request #409: add year 2023 to Notice files

2023-05-15 Thread via GitHub
nikita15p commented on PR #409: URL: https://github.com/apache/flume/pull/409#issuecomment-1547411871 Looks good to me. Cc @busbey @rgoers can u please approve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flume] busbey commented on a diff in pull request #409: add year 2023 to Notice files

2023-05-15 Thread via GitHub
busbey commented on code in PR #409: URL: https://github.com/apache/flume/pull/409#discussion_r1193946950 ## flume-ng-dist/src/main/appended-resources/META-INF/NOTICE: ## @@ -217,8 +217,8 @@ source: https://www.opensource.apple.com/source/configd/configd-453.19/dnsinfo/d

[GitHub] [flume] yangjf2019 commented on pull request #409: add year 2023 to Notice files

2023-05-15 Thread via GitHub
yangjf2019 commented on PR #409: URL: https://github.com/apache/flume/pull/409#issuecomment-1548875819 > flume-ng-clients/flume-ng-log4jappender/src/main/resources-for-jar-with-deps/META-INF/NOTICE Thanks for your review.I updated. -- This is an automated message from the Apache

[GitHub] [flume] yangjf2019 commented on a diff in pull request #409: add year 2023 to Notice files

2023-05-15 Thread via GitHub
yangjf2019 commented on code in PR #409: URL: https://github.com/apache/flume/pull/409#discussion_r1194535354 ## flume-ng-dist/src/main/appended-resources/META-INF/NOTICE: ## @@ -217,8 +217,8 @@ source: https://www.opensource.apple.com/source/configd/configd-453.19/dnsinfo/d

[GitHub] [flume] changeAtLater opened a new pull request, #410: fix JSONEvent charset bug

2023-05-11 Thread via GitHub
changeAtLater opened a new pull request, #410: URL: https://github.com/apache/flume/pull/410 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flume-jdbc] deepak-garg opened a new pull request, #1: FLUME-3475 - Upgrade commons-dbcp to commons-dbcp2

2023-05-12 Thread via GitHub
deepak-garg opened a new pull request, #1: URL: https://github.com/apache/flume-jdbc/pull/1 https://issues.apache.org/jira/browse/FLUME-3475 -> Please refer above ticket for the logs after this change. Specific testcases related to jdbc-channel and all the testcases for the flume

[GitHub] [flume-jdbc] deepak-garg commented on pull request #1: FLUME-3475 - Upgrade commons-dbcp to commons-dbcp2

2023-05-12 Thread via GitHub
deepak-garg commented on PR #1: URL: https://github.com/apache/flume-jdbc/pull/1#issuecomment-1546021935 @rgoers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLUME-3480] remove log4j 1.2.17 due to eol [flume]

2023-11-18 Thread via GitHub
rgoers commented on PR #418: URL: https://github.com/apache/flume/pull/418#issuecomment-1817748485 This PR says log4j 1 is used in the build-support module but the PR doesn't show that. The Log4j 1 Appender should simmply be removed. Log4j 2 already provides a Flume Appender and now that

Re: [PR] [FLUME-3480] remove log4j 1.2.17 due to eol [flume]

2023-11-18 Thread via GitHub
rgoers closed pull request #418: [FLUME-3480] remove log4j 1.2.17 due to eol URL: https://github.com/apache/flume/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    1   2