[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532585#comment-15532585
 ] 

Bessenyei Balázs Donát edited comment on FLUME-2998 at 9/30/16 10:26 AM:
-------------------------------------------------------------------------

[~sati]: thank you for the patch!

* What do you mean by "practically" in the first line of the change?
* nit: "Retry if put failed." -> "Retries when it can't send events to the 
channel."

Side note: this would be the first parameter in the documentation with a Java 
constant ("Long.MAX_VALUE") for default. Do we want to maybe put numbers there 
instead?


was (Author: bessbd):
[~sati]: thank you for the patch!

* What do you mean be "practically" in the first line of the change?
* nit: "Retry if put failed." -> "Retries when it can't send events to the 
channel."

Side note: this would be the first parameter in the documentation with a Java 
constant ("Long.MAX_VALUE") for default. Do we want to maybe put numbers there 
instead?

> Add missing configuration parameter to SequenceSource docs
> ----------------------------------------------------------
>
>                 Key: FLUME-2998
>                 URL: https://issues.apache.org/jira/browse/FLUME-2998
>             Project: Flume
>          Issue Type: Documentation
>          Components: Docs
>    Affects Versions: v1.7.0
>            Reporter: Attila Simon
>            Assignee: Attila Simon
>             Fix For: v1.7.0
>
>         Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to