[jira] [Commented] (FLUME-2959) flume-checkstyle module should be consistent with flume-ng prefix convention
[ https://issues.apache.org/jira/browse/FLUME-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396139#comment-15396139 ] Mike Percy commented on FLUME-2959: --- bq. I'm not a big fan of the flume-ng prefix either, but I do think we should have a consistent module naming convention. Yeah, I agree that maintaining consistency often helps understandability. I also think we should stop doing things when they aren't useful and IMHO this is one of those things. Thanks for figuring out why the build was complaining, the patch looks good. +1 > flume-checkstyle module should be consistent with flume-ng prefix convention > > > Key: FLUME-2959 > URL: https://issues.apache.org/jira/browse/FLUME-2959 > Project: Flume > Issue Type: Improvement >Reporter: Lior Zeno >Assignee: Lior Zeno >Priority: Minor > Fix For: v1.7.0 > > Attachments: FLUME-2959-0.patch, FLUME-2959-1.patch > > > In FLUME-2937 we added the flume-checkstyle module to Flume. > There are three minor issues with it: > # It does not follow our modules naming convention. It should be > flume-ng-checkstyle. > # It does not declare a parent module, resulting in build warnings (the > source encoding is not explicitly set to UTF-8) > # Resource files don't include the ASF licensing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2959) flume-checkstyle module should be consistent with flume-ng prefix convention
[
https://issues.apache.org/jira/browse/FLUME-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395973#comment-15395973
]
Lior Zeno commented on FLUME-2959:
--
{quote}
I don't think the -ng stuff is really helpful and I don't think we need to
change it. We do already have flume-tools that is missing the -ng suffix so
it's not unprecedented.
{quote}
I'm not a big fan of the flume-ng prefix either, but I do think we should have
a consistent module naming convention.
{quote}
The POM should not have flume-parent as a parent because then it would have
itself as a dependency which is strange. Maybe we should just specify UTF-8 as
the encoding if that is the problem.
{quote}
I've submitted a new patch.
Thanks.
> flume-checkstyle module should be consistent with flume-ng prefix convention
>
>
> Key: FLUME-2959
> URL: https://issues.apache.org/jira/browse/FLUME-2959
> Project: Flume
> Issue Type: Improvement
>Reporter: Lior Zeno
>Assignee: Lior Zeno
>Priority: Minor
> Fix For: v1.7.0
>
> Attachments: FLUME-2959-0.patch, FLUME-2959-1.patch
>
>
> In FLUME-2937 we added the flume-checkstyle module to Flume.
> There are three minor issues with it:
> # It does not follow our modules naming convention. It should be
> flume-ng-checkstyle.
> # It does not declare a parent module, resulting in build warnings (the
> source encoding is not explicitly set to UTF-8)
> # Resource files don't include the ASF licensing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLUME-2959) flume-checkstyle module should be consistent with flume-ng prefix convention
[ https://issues.apache.org/jira/browse/FLUME-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393413#comment-15393413 ] Mike Percy commented on FLUME-2959: --- Thanks for the patch, Lior. Some review feedback: 1. I don't think the -ng stuff is really helpful and I don't think we need to change it. We do already have flume-tools that is missing the -ng suffix so it's not unprecedented. 2. The POM should not have flume-parent as a parent because then it would have itself as a dependency which is strange. Maybe we should just specify UTF-8 as the encoding if that is the problem. 3. Good point, the ASL2.0 license should be included at the top of the XML files. > flume-checkstyle module should be consistent with flume-ng prefix convention > > > Key: FLUME-2959 > URL: https://issues.apache.org/jira/browse/FLUME-2959 > Project: Flume > Issue Type: Improvement >Reporter: Lior Zeno >Assignee: Lior Zeno >Priority: Minor > Fix For: v1.7.0 > > Attachments: FLUME-2959-0.patch > > > In FLUME-2937 we added the flume-checkstyle module to Flume. > There are three minor issues with it: > # It does not follow our modules naming convention. It should be > flume-ng-checkstyle. > # It does not declare a parent module, resulting in build warnings (the > source encoding is not explicitly set to UTF-8) > # Resource files don't include the ASF licensing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
