B. Todd Burruss created FLUME-2290:
--------------------------------------

             Summary: AbstractRpcSink does not properly shutdown the 
cxnResetExecutor executor and its tasks
                 Key: FLUME-2290
                 URL: https://issues.apache.org/jira/browse/FLUME-2290
             Project: Flume
          Issue Type: Bug
    Affects Versions: v1.4.0
         Environment: Linux
java version "1.6.0_38"
Java(TM) SE Runtime Environment (build 1.6.0_38-b05)
Java HotSpot(TM) 64-Bit Server VM (build 20.13-b02, mixed mode)

            Reporter: B. Todd Burruss


in the AbstactRpcSink.stop() method, cxnResetExecutor.shutdown() is called, but 
this will not terminate scheduled tasks.  you must explicitly cancel the task.

however, i believe you guys tried to handle this because of the call to 
cxnResetExecutor.awaitTermination(), but mishandled the return code.  if 
"false" is returned you want to call cxnResetExecutor.shutdownNow(), not if 
true is returned.

my recommendation is to capture the ScheduledFuture returned and cancel the 
task explicitly after calling cxnResetExecutor.shutdown().  then if 
awaitTermination still doesn't work, call cxnResetExecutor.shutdownNow()



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to