Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-05-12 Thread Justin Mclean
Hi, Just a really minor trivial thing, for your next release you might want to update the year in the NOTICE file to include the current year. Thanks, Justin

[RESULT][VOTE] Release Apache FreeMarker 2.3.31

2021-02-16 Thread Daniel Dekany
Vote for releasing Apache FreeMarker 2.3.31 passed with the following results: 4 "+1" binding votes, no "0" votes, no "-1" votes. Thus, this version is recommended for release by the PMC, and I will continue with the release steps, and announce the new release about 24 hours from now. Daniel

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-16 Thread Daniel Dekany
+1 (binding) I was the release engineer, and didn't notice anything out of order. I also tested the release with FMPP (test suite passes), and Docgen (generates exactly the same output for the FreeMarker Manual). On Tue, Feb 9, 2021 at 11:19 PM Daniel Dekany wrote: > Hi all, > > Please vote

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-13 Thread Jacques Le Roux
+1 (binding) Tested in OFBiz trunk HEAD, UI and console OK. I even spotted an old small issue in log that did not show before :) Jacques Le 13/02/2021 à 12:31, Siegfried Goeschl a écrit : +1 (non-binding) Tested with freemarker-generator Thanks in advance, Siegfried Goeschl On

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-13 Thread Siegfried Goeschl
+1 (non-binding) Tested with freemarker-generator Thanks in advance, Siegfried Goeschl > On 12.02.2021, at 20:12, Christoph Rüger wrote: > > +1 (non-binding) > > Verified running our testsuite containing some FM related tests > with org.freemarker.freemarker-2.3.31.jar . > no regression

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-12 Thread Christoph Rüger
+1 (non-binding) Verified running our testsuite containing some FM related tests with org.freemarker.freemarker-2.3.31.jar . no regression found, all testcases successful. Regards Christoph Am Mi., 10. Feb. 2021 um 23:51 Uhr schrieb Woonsan Ko : > +1 (binding) > > Verified the following: > -

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Woonsan Ko
+1 (binding) Verified the following: - gpg --verify with the .asc files: OK - sha512 checksums: OK - builds and artifacts in both "normal" and "gae": OK (ant, ant test, ant javadoc, ant manualOffline, ant maven-install) - testing in a CMS product with the freemarker-2.3.31.jar: OK Regards,

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Jacopo Cappellato
+1 (binding) checksum, signature, build and tests are all successful. Jacopo Cappellato On Tue, Feb 9, 2021 at 11:20 PM Daniel Dekany wrote: > > Hi all, > > Please vote on releasing FreeMarker 2.3.31! > > As there were changes in the last few days, don't skip testing with > your dependent

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Daniel Dekany
Ah, indeed, ARM allows reordering stores and such. I don't think the test suite (that runs on Travis on ARM) has much chance to uncover such bugs, if any exists. FM has not-so-trivial concurrency at a few places. But at least I never assumed anything that the JVM memory model doesn't guarantee.

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Martin Grigorov
Hi, On Wed, Feb 10, 2021 at 11:23 AM Daniel Dekany wrote: > Ah yes. I forgot to add the build and CI related improvements from the > release notes (there were others too). I will add those to the version > history post release (can't modify artifacts being voted upon). > > But I think it will

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Daniel Dekany
Ah yes. I forgot to add the build and CI related improvements from the release notes (there were others too). I will add those to the version history post release (can't modify artifacts being voted upon). But I think it will be soon taken as granted that all Java libraries work on ARM (unless

Re: [VOTE] Release Apache FreeMarker 2.3.31

2021-02-10 Thread Emilio Fernandes
Hi, On 2021/02/09 22:19:49, Daniel Dekany wrote: > Hi all, > > Please vote on releasing FreeMarker 2.3.31! > > As there were changes in the last few days, don't skip testing with > your dependent projects, even if you already did it recently. > > Release Notes: >

[VOTE] Release Apache FreeMarker 2.3.31

2021-02-09 Thread Daniel Dekany
Hi all, Please vote on releasing FreeMarker 2.3.31! As there were changes in the last few days, don't skip testing with your dependent projects, even if you already did it recently. Release Notes: https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html Before proceed, you