Re: Help needed for FREEMARKER-148 ...

2020-07-05 Thread Daniel Dekany
On Sun, Jul 5, 2020 at 4:19 PM Siegfried Goeschl < siegfried.goes...@gmail.com> wrote: > See my comments inline ... > > > On 05.07.2020, at 15:25, Daniel Dekany wrote: > > > > See my comments inline... > > > > On Sun, Jul 5, 2020 at 2:49 PM Siegfried Goeschl < > > siegfried.goes...@gmail.com

Re: Help needed for FREEMARKER-148 ...

2020-07-05 Thread Siegfried Goeschl
See my comments inline ... > On 05.07.2020, at 15:25, Daniel Dekany wrote: > > See my comments inline... > > On Sun, Jul 5, 2020 at 2:49 PM Siegfried Goeschl < > siegfried.goes...@gmail.com > wrote: > >> Hi Daniel, >> >> Please see my comments below >> >>

Re: Help needed for FREEMARKER-148 ...

2020-07-05 Thread Daniel Dekany
See my comments inline... On Sun, Jul 5, 2020 at 2:49 PM Siegfried Goeschl < siegfried.goes...@gmail.com> wrote: > Hi Daniel, > > Please see my comments below > > Thanks in advance, > > Siegfried Goeschl > > > > > On 05.07.2020, at 13:42, Daniel Dekany wrote: > > > > The reason I was asking is

Re: Help needed for FREEMARKER-148 ...

2020-07-05 Thread Daniel Dekany
The reason I was asking is that if all functionality goes in DataSourcers, the methods will shadow data source names. Like if you have a data source named "empty", then DataSources.empty will not return that, instead it will call isEmpty(). That also means that adding new methods to DataSource is

Re: Help needed for FREEMARKER-148 ...

2020-07-04 Thread Siegfried Goeschl
Hi Daniel, Please see the examples in https://issues.apache.org/jira/browse/FREEMARKER-148 Thanks in advance, Siegfried Goeschl > On 03.07.2020, at 23:25, Daniel Dekany wrote: > > How do you intend to have map semantics and still

Re: Help needed for FREEMARKER-148 ...

2020-07-03 Thread Daniel Dekany
How do you intend to have map semantics and still expose helper methods? I'm not asking how would you implement that, but how would it look in the templates? On Tue, Jun 30, 2020 at 9:28 PM Siegfried Goeschl < siegfried.goes...@gmail.com> wrote: > Hi folks, > > Following up a discussion with

Re: Help needed for FREEMARKER-148 ...

2020-06-30 Thread Siegfried Goeschl
Sounds like a plan :-) > On 30.06.2020, at 22:56, Woonsan Ko wrote: > > On Tue, Jun 30, 2020 at 3:28 PM Siegfried Goeschl > mailto:siegfried.goes...@gmail.com>> wrote: >> >> Hi folks, >> >> Following up a discussion with Daniel I would like to make "DataSources" >> (contains the

Re: Help needed for FREEMARKER-148 ...

2020-06-30 Thread Woonsan Ko
On Tue, Jun 30, 2020 at 3:28 PM Siegfried Goeschl wrote: > > Hi folks, > > Following up a discussion with Daniel I would like to make "DataSources" > (contains the user-supplied data sources) a bit more FTL friendly > > Had a quick look at it but I'm a bit lost > I created a DataSourcesAdapter

Help needed for FREEMARKER-148 ...

2020-06-30 Thread Siegfried Goeschl
Hi folks, Following up a discussion with Daniel I would like to make "DataSources" (contains the user-supplied data sources) a bit more FTL friendly Had a quick look at it but I'm a bit lost I created a DataSourcesAdapter which extends TemplateSequenceModel & TemplateHashModel DataSources has