Re: Adding a new BuiltIn - previousSibling

2015-10-14 Thread Daniel Dekany
I'm not sure what's improper in the result (I don't know what was expected). Isn't that node preceded by white space? That would explain it. You might rather want the previous *element*. But that will be difficult to express on the TemplateNodeModel level, which is not bound to XML. One important

Re: template inclusions cause stackoverflowerror

2015-10-14 Thread Daniel Dekany
Thanks, I will review it more closely as soon as I get to it... like there's a slight hope that it will happen this weekend. Others, please look at this patch and tell your opinions, if you find the time! As of me, I have finally decided to let this change in (unless I will find some new issue I h

Re: Number format configuration option

2015-10-14 Thread Daniel Dekany
There are substantial new features in the upcoming release (2.3.24) regarding formatting, though their purpose is adding new functionality, rather than streamlining configuration (which is what you aim for, if I understand well), which you usually only do once or so. If you check out the head (the

Adding a new BuiltIn - previousSibling

2015-10-14 Thread Pradeep Murugesan
Hi Daniel, I tried to add a new built in & of course it DIDN'T work 😢. I did the following. 1. added putBI("previousSibling", new previousSiblingBI()); in BuiltIn.java2. added a static class in BuiltInForNodes.java static class previousSiblingBI extends BuiltInForNode { @Overr

RE: Freemarker manual Local set up

2015-10-14 Thread Pradeep Murugesan
Yeah.. We need to have a builtin something like ?previousSibling & ?followingSibling. Shall I implement that change as well in freemarker ? Pradeep. > Date: Tue, 13 Oct 2015 23:52:54 +0200 > From: ddek...@freemail.hu > To: dev@freemarker.incubator.apache.org > Subject: Re: Freemarker manual Loca

Re: template inclusions cause stackoverflowerror

2015-10-14 Thread Kleine, Moritz
Hi, here¹s the 2.3-gae pull request https://github.com/apache/incubator-freemarker/pull/6 Regards, Moritz On 9/11/15, 7:49 PM, "Daniel Dekany" wrote: >It surely consumes less stack this way, though stack usage doesn't >used to be an concern (barring FTL sequence concatenations in a loop, >but th