Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating, attempt 2

2016-01-11 Thread Kleine, Moritz
Hi all, CoreMedia has tested RC01 and is happy with it. Regards, Moritz On 1/10/16, 8:15 PM, "Daniel Dekany" wrote: >The finishing of 2.3.24 is now goes on on the >"2.3.24-gae-stabilization" branch. Meanwhile, the development of >2.3.25 has been started on the "2.3-gae"

Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating, attempt 2

2016-01-11 Thread Sergio Fernández
Hi Daniel, one question: how can I run RAT? In the previous RC the procesdure was: $ ant dist $ ant rat But the first one fails because "All boot.classpath properties must be set in build.properties for dist!", so also the second as expected: "build/dist/src does not exist". On Thu, Jan 7,

Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating

2016-01-11 Thread Ralph Goers
Actually, you can deploy SNAPSHOTs from a Jenkins job every day if you want to. They aren’t releases. I believe the only purpose that section serves is to let you verify that your settings are correct and that you have permission to deploy to the repository. Note that what you are deploying to

Re: Adding a new BuiltIn - previousSibling

2016-01-11 Thread Pradeep Murugesan
Hi Daniel, I did the merge with the branch gae-2.3. Once I build and run the tests I am getting the following error message Caused by: java.lang.RuntimeException: Clashing FreeMarker versions (2.3.24-rc01-incubating and some post-2.3.x) detected: found post-2.3.x class

Re: Adding a new BuiltIn - previousSibling

2016-01-11 Thread Pradeep Murugesan
I did a clean and then built. Its working fine now. Sent a pull request, https://github.com/apache/incubator-freemarker/pull/9 Kindly review and let me know. Pradeep. From: Pradeep Murugesan Sent: Monday, January 11,

Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating, attempt 2

2016-01-11 Thread Daniel Dekany
Monday, January 11, 2016, 11:17:17 AM, Sergio Fernández wrote: > Hi Daniel, one question: how can I run RAT? > > In the previous RC the procesdure was: > > $ ant dist > $ ant rat > > But the first one fails because "All boot.classpath properties must > be set in build.properties for dist!", so

Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating

2016-01-11 Thread Daniel Dekany
Sure, I only ever push standard Maven artifacts (jar, source, javadoc) to Nexus. For distributing non-Maven non-official artifacts there's https://dist.apache.org/repos/dist/dev/. -- Thanks, Daniel Dekany Monday, January 11, 2016, 5:06:01 PM, Ralph Goers wrote: > Actually, you can deploy

Re: [VOTE] Release FreeMarker 2.3.24-rc01-incubating, attempt 2

2016-01-11 Thread Daniel Dekany
All right then, and thanks for the feedback! -- Thanks, Daniel Dekany Monday, January 11, 2016, 9:02:17 AM, Kleine, Moritz wrote: > Hi all, CoreMedia has tested RC01 and is happy with it. > Regards, > Moritz > > On 1/10/16, 8:15 PM, "Daniel Dekany" wrote: > >>The

Re: Adding a new BuiltIn - previousSibling

2016-01-11 Thread Daniel Dekany
Some minor issues I have noticed at a quick glance: - You have added some unused special-variable constants - You are using a mutable List as EMPTY_LIST constant (you could use Collections.emptyList()) - node.getTextContent().toCharArray(): Can't getTextContent() be null? Also what we need is