Re: Proposal: Extended FreemarkerServlet response Content-type and charset logic (Was: Re: Just created content-type and locale issues in JIRA)

2015-10-21 Thread Daniel Dekany
I have committed the OverrideResponseContentType always/never/whenTemplateHasMimeType thing. (Also did some further cleanup.) So update before you modify anything. -- Thanks, Daniel Dekany Wednesday, October 21, 2015, 3:19:06 AM, Woonsan Ko wrote: > On Wed, Oct 21, 2015 at 5:12 AM, Daniel Dek

Re: Proposal: Extended FreemarkerServlet response Content-type and charset logic (Was: Re: Just created content-type and locale issues in JIRA)

2015-10-20 Thread Woonsan Ko
On Wed, Oct 21, 2015 at 5:12 AM, Daniel Dekany wrote: > Tuesday, October 20, 2015, 6:08:33 AM, Woonsan Ko wrote: > >> Hi Daniel, >> >> Thanks a lot for the reasonable/thorough analysis and solutions! >> Yes, your proposal will solve our problem (FREEMARKER-1). We can >> probably set it to "never"

Re: Proposal: Extended FreemarkerServlet response Content-type and charset logic (Was: Re: Just created content-type and locale issues in JIRA)

2015-10-20 Thread Daniel Dekany
Tuesday, October 20, 2015, 6:08:33 AM, Woonsan Ko wrote: > Hi Daniel, > > Thanks a lot for the reasonable/thorough analysis and solutions! > Yes, your proposal will solve our problem (FREEMARKER-1). We can > probably set it to "never" in our default configuration. > > In our case, our MVC framewor

Re: Proposal: Extended FreemarkerServlet response Content-type and charset logic (Was: Re: Just created content-type and locale issues in JIRA)

2015-10-19 Thread Woonsan Ko
Hi Daniel, Thanks a lot for the reasonable/thorough analysis and solutions! Yes, your proposal will solve our problem (FREEMARKER-1). We can probably set it to "never" in our default configuration. In our case, our MVC framework allows developers to set response content type to anything before di

Proposal: Extended FreemarkerServlet response Content-type and charset logic (Was: Re: Just created content-type and locale issues in JIRA)

2015-10-18 Thread Daniel Dekany
So I have merged this (https://issues.apache.org/jira/browse/FREEMARKER-1) in, but while reviewing the stuff, I have realized that I'm not sure how exactly this should work, especially as OutputFormat-s (the main 2.3.24 feature, mostly used for auto-escaping, but usually also specifies a MIME type)