[GitHub] incubator-gearpump pull request #163: GEARPUMP-279 akka-streams test example...

2017-02-27 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/163 GEARPUMP-279 akka-streams test examples do not work Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] incubator-gearpump issue #119: [GEARPUMP-246] Invoke GroupByFunction.apply i...

2016-12-07 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/119 +1 - for Apache Beam I assume. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-gearpump issue #116: [GEARPUMP-243] Add missing license headers an...

2016-12-02 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/116 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #115: Add 0.8.2 release notes and bump up version

2016-11-30 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/115 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #114: [GEARPUMP-241] Update CHANGELOG.md to ...

2016-11-16 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/114 [GEARPUMP-241] Update CHANGELOG.md to reflect all JIRA's You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator

[GitHub] incubator-gearpump pull request #112: [GEARPUMP-239] Correct binary and sour...

2016-11-16 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/112 [GEARPUMP-239] Correct binary and source licenses subdirectory You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator

[GitHub] incubator-gearpump issue #111: [GEARPUMP-238] Correct release naming and pac...

2016-11-15 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/111 @manuzhang please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-gearpump pull request #111: [GEARPUMP-238] Correct release naming ...

2016-11-15 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/111 [GEARPUMP-238] Correct release naming and packaging You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump

[GitHub] incubator-gearpump issue #110: [GEARPUMP-237] remove manually downloading sb...

2016-11-15 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/110 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...

2016-11-11 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/109 @manuzhang looks like #108 is in. I'll add the JIRA to CHANGELOG.md and recreate the artifacts. Do you remember if I used 0.8.1.RC[0-9] for version or 0.8.1? I'll look at the github

[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...

2016-11-11 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/109 @manuzhang Let's wait for #108 as you noted above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-gearpump pull request #109: Fixes GEARPUMP-234 Update LICENSE and ...

2016-11-11 Thread kkasravi
Github user kkasravi commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/109#discussion_r87679023 --- Diff: LICENSE.bin --- @@ -0,0 +1,349 @@ + Apache License --- End diff -- @manuzhang we were

[GitHub] incubator-gearpump pull request #105: Gearpump 206

2016-11-01 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/105 Gearpump 206 Still implementing upstream, downstream access but the flow is now working You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-gearpump issue #101: [GEARPUMP-227] remove unneeded licenses

2016-10-29 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/101 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #94: Fixes #22 support akka-streams Gearpump Materi...

2016-10-10 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/94 Thanks @manuzhang - closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-gearpump pull request #94: Fixes #22 support akka-streams Gearpump...

2016-10-10 Thread kkasravi
Github user kkasravi closed the pull request at: https://github.com/apache/incubator-gearpump/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #94: Fixes #22 support akka-streams Gearpump...

2016-10-10 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/94 Fixes #22 support akka-streams Gearpump Materializer You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump

[GitHub] incubator-gearpump issue #85: [GEARPUMP-23] add window dsl

2016-10-06 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/85 +1 let's get this merged and i'll rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-gearpump issue #88: [GEARPUMP-213] build docs with MkDocs

2016-09-29 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/88 +1 - though i haven't seen the output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-gearpump pull request #85: [GEARPUMP-23] add window dsl

2016-09-27 Thread kkasravi
Github user kkasravi commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/85#discussion_r80745374 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/Stream.scala --- @@ -147,6 +150,33 @@ class Stream[T

[GitHub] incubator-gearpump pull request #85: [GEARPUMP-23] add window dsl

2016-09-27 Thread kkasravi
Github user kkasravi commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/85#discussion_r80744615 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/Stream.scala --- @@ -115,20 +121,17 @@ class Stream[T

[GitHub] incubator-gearpump pull request #76: Fixes #22 support akka-streams Gearpump...

2016-08-25 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/76 Fixes #22 support akka-streams Gearpump Materializer DO NOT MERGE AT THIS TIME You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-gearpump issue #75: fix GEARPUMP-189 Update project/Build.scala to...

2016-08-17 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/75 I don't think so. Things were pushed to https://repository.apache.org/content/repositories/releases/org/apache/gearpump when I did a local 'sbt publish'. Although it also looks like

[GitHub] incubator-gearpump pull request #75: fix GEARPUMP-189 Update project/Build.s...

2016-08-15 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/75 fix GEARPUMP-189 Update project/Build.scala to enable publishing rele… …ases to https://repository.apache.org/content/repositories/releases/org/apache/gearpump/ You can merge

[GitHub] incubator-gearpump pull request #70: fix GEARPUMP-186 Create 0.8.1 release

2016-08-10 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/70 fix GEARPUMP-186 Create 0.8.1 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-186

[GitHub] incubator-gearpump issue #69: [GEARPUMP-184] Create 0.8.1-RC5 release

2016-07-30 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/69 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #68: fix licenses

2016-07-29 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/68 +1 but is there JIRA #? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump pull request #65: fix GEARPUMP-181 Create 0.8.1-RC4 relea...

2016-07-18 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/65 fix GEARPUMP-181 Create 0.8.1-RC4 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-181

[GitHub] incubator-gearpump pull request #61: fix GEARPUMP-178 Create 0.8.1-RC3 relea...

2016-07-09 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/61 fix GEARPUMP-178 Create 0.8.1-RC3 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-178

[GitHub] incubator-gearpump pull request #59: fix GEARPUMP-176 Create 0.8.1-RC2 relea...

2016-07-07 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/59 fix GEARPUMP-176 Create 0.8.1-RC2 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-176

[GitHub] incubator-gearpump issue #46: fixes GEARPUMP-156 Replace logo in site, GitHu...

2016-06-30 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/46 @huafengw fixed in GEARPUMP-159 (https://github.com/apache/incubator-gearpump/pull/47) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-gearpump issue #47: fixes GEARPUMP-159 Prep for first release

2016-06-24 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/47 For this PR, we shouldn't merge until we've voted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-gearpump pull request #47: fixes GEARPUMP-159 Prep for first relea...

2016-06-22 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/47 fixes GEARPUMP-159 Prep for first release You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-159

[GitHub] incubator-gearpump pull request #46: fixes GEARPUMP-156 Replace logo in site...

2016-06-22 Thread kkasravi
GitHub user kkasravi opened a pull request: https://github.com/apache/incubator-gearpump/pull/46 fixes GEARPUMP-156 Replace logo in site, GitHub, Travis, etc You can merge this pull request into a Git repository by running: $ git pull https://github.com/kkasravi/incubator

[GitHub] incubator-gearpump issue #34: fix GEARPUMP-153, throw exception on main clas...

2016-06-22 Thread kkasravi
Github user kkasravi commented on the issue: https://github.com/apache/incubator-gearpump/pull/34 +1 I'm ok with requiring the main class to be named if you have arguments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-gearpump pull request: fix GEARPUMP-118 change package n...

2016-05-10 Thread kkasravi
Github user kkasravi commented on the pull request: https://github.com/apache/incubator-gearpump/pull/14#issuecomment-218072073 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-gearpump pull request: fix #106 Gearpump Redis Integrati...

2016-05-07 Thread kkasravi
Github user kkasravi commented on the pull request: https://github.com/apache/incubator-gearpump/pull/11#issuecomment-217654539 @darionyaphet we probably need some unit tests. Good job on splitting example and actual definitions into example and external. It doesn't look like

[GitHub] incubator-gearpump pull request: gearpump-34 update developer docu...

2016-05-02 Thread kkasravi
Github user kkasravi commented on the pull request: https://github.com/apache/incubator-gearpump/pull/1#issuecomment-216317646 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature