GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/250
[GEARPUMP-326] Upgrade Akka to 2.5.13 (remove akkastream module tempoâ¦
â¦rarily)
Be sure to do all of the following to help us incorporate your contribution
quickly
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/248
[WIP] Use scala-graph for internal graph implementation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/247
Yes, almost identical tweets output. Any suggestions here ?
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/247
R: @huafengw
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186253708
--- Diff:
external/kudu/src/main/scala/org/apache/gearpump/external/kudu/dsl/KuduDSLSink.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186253573
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/Split.scala
---
@@ -0,0 +1,45
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/247
[GEARPUMP-377] Add TwitterSource and examples
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186255767
--- Diff:
external/kudu/src/main/scala/org/apache/gearpump/external/kudu/dsl/KuduDSLSink.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/246
BTW, please start your commit message with `[GEARPUMP-376]`
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186255774
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/Split.scala
---
@@ -0,0 +1,45
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186249256
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/Split.scala
---
@@ -0,0 +1,45
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r186249231
--- Diff:
external/kudu/src/main/scala/org/apache/gearpump/external/kudu/dsl/KuduDSLSink.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185995143
--- Diff:
external/kudu/src/main/scala/org/apache/gearpump/external/kudu/KuduSink.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185995392
--- Diff:
external/kudu/src/main/scala/org/apache/gearpump/external/kudu/dsl/KuduDSLSink.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/246
@SandishKumarHN Thanks for your contribution. I've left some comments.
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185995603
--- Diff: project/Dependencies.scala ---
@@ -35,6 +35,7 @@ object Dependencies {
val upickleVersion = "0.3.4"
val ju
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185995517
--- Diff:
external/kudu/src/test/scala/org/apache/gearpump/external/kudu/KuduSinkSpec.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185995108
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/KuduConn.scala
---
@@ -0,0 +1,80
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185994874
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/Split.scala
---
@@ -0,0 +1,45
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/246#discussion_r185994813
--- Diff:
examples/streaming/kudu/src/main/scala/org/apache/gearpump/streaming/examples/kudu/KuduConn.scala
---
@@ -0,0 +1,80
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/245
[WIP] Upickle -> Json4s
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is format
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
LGTM +1
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Actually, those requiring `RemoteRuntimeEnvironment` are commands that
interact with `Master`. So how about `MasterClientCommand` ? This also solves
your second question.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/243
R: @huafengw
---
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/243
[GEARPUMP-339] Fix unknown tag parameter
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
The root cause of this issue is that apps submitted from UI via
`AppSubmitter` or `GearpumpStormClient` are run in the default
`EmbeddedRuntimeEnvironment`.
Currently
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Maybe we'd better change the default runtime environment to `Remote` rather
than `Embedded`. It's easy to forget to set it.
@huafengw may have some comments on this.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
R: @huafengw
The failed test `AppMasterSpec` is unrelated to this PR.
---
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/242
[GEARPUMP-369] Fix configuring number of executors
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/242
R: @huafengw
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/227
@huafengw This can be closed now
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
1. `WindowRunner` => `TimedValueProcessor` which processes
`TimestampedValue` and emit `TriggeredOutputs` on trigger
2. Add a subclass `DirectProcessor` which proces
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/239
@huafengw
---
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/239
[GEARPUMP-366] Create JarStore dir if not exists on job submit
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/240
[GEARPUMP-344] Fix broken links in README
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/240
R: @huafengw
---
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/238
[GEARPUMP-350] Fix app clock not started
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/237
Committed to master with adding JIRA issue id to commit message. Thanks for
your contribution !
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/237
@hepin1989 Thanks for the PR. Would you mind creating an issue at
https://issues.apache.org/jira/projects/GEARPUMP and updating your commit
message to `[GEARPUMP-XXX] Upgrade to sbt
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/236
LGTM
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
@huafengw can't reproduce 1 and 3 on Mac
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/234
LGTM. Merged with fixing the nitpick
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
@karol-brejna-i @huafengw rebased. Please help to verify again
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/234#discussion_r147105502
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala
---
@@ -209,7 +202,8 @@ class Subscription
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/235
Great ! Could you create a JIRA issue and update your commit comment
accordingly ?
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/227#discussion_r147024843
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala
---
@@ -27,15 +27,15 @@ import
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/227#discussion_r147025062
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala
---
@@ -27,15 +27,15 @@ import
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
It seems python package is not supported by busybox. Can we switch to the
official `openjdk/8-jre-alpine` image ? It's 120MB after installing python.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/233
R: @karol-brejna-i @huafengw Build Gearpump Image locally to make it easier
to update and fix bugs
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/231
merging. Thanks.
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r146002316
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +65,40 @@ class
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/233
[WIP] Fix integration test
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r145601401
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +64,38 @@ class
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r145602273
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +64,38 @@ class
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r145601399
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +64,38 @@ class
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r145602797
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +64,38 @@ class
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/231#discussion_r145602983
--- Diff:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/client/AppMasterResolver.scala
---
@@ -75,3 +64,38 @@ class
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/231
@titikakatoo Added some comments. BTW, can upgrade http client version fix
the issue ?
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/232
LGTM
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/231
R: @huafengw
---
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/229#discussion_r143989762
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala
---
@@ -61,9 +61,9 @@ class Subscription
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/230
R: @karol-brejna-i @huafengw
---
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/226
[WIP] Don't use window runner for non-folding function
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/226#discussion_r141615634
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala
---
@@ -73,6 +73,25 @@ case class AndThen
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/225#discussion_r139435394
--- Diff:
experiments/sql/src/test/java/org/apache/gearpump/sql/planner/CalciteTest.java
---
@@ -291,17 +290,25 @@ void calTest() throws
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/225#discussion_r139435162
--- Diff:
experiments/sql/src/test/java/org/apache/gearpump/sql/planner/CalciteTest.java
---
@@ -80,19 +80,38 @@
private RexExecutor
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139280373
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -318,12 +360,8 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139061587
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +258,36 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139049560
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -156,64 +155,64 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r139049164
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875669
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -165,7 +181,7 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138873545
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875439
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -28,6 +29,8 @@ class Graph[N, E](vertexList: List[N], edgeList: List
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876553
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -318,11 +355,12 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876219
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875971
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
We also do an extra check for cycle here. Can it be removed ?
```scala
if (dag.hasCycle()) {
LOG.warn(s"Detected cycles in DAG of application
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138876832
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138879455
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -28,6 +29,8 @@ class Graph[N, E](vertexList: List[N], edgeList: List
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138883853
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/223#discussion_r138884320
--- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
@@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
Verified Beam ValidatesRunnerTests can be run much faster now.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/224
LGTM
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
@huafengw could you explain a bit why it's faster now.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/222
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/221
R: @huafengw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user manuzhang closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/221
[GEARPUMP-217] Merge sql branch into master
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/220
[GEARPUMP-217] Merge sql branch into master
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/219
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/219
This PR has been merged. You can close now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/218
R: @huafengw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user manuzhang closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/218
[GEARPUMP-217] Merge master into sql branch
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/217
@buddhiayesha2015 The PR has been merged. You may close it now (it cannot
be automatically closed for merging into feature branch)
---
If your project is set up for it, you can reply
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/217#discussion_r133892457
--- Diff:
experiments/sql/src/main/java/org/apache/gearpump/sql/rel/GearAggregationRel.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/217#discussion_r133879510
--- Diff:
examples/streaming/wordcount-java/src/test/java/org/apache/gearpump/streaming/examples/wordcountjava/WordCountSpecJava.java
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/217#discussion_r133879776
--- Diff:
examples/streaming/wordcount-java/src/test/java/org/apache/gearpump/streaming/examples/wordcountjava/WordCountSpecJava.java
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/215
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 474 matches
Mail list logo
