[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-18 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 @huafengw updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-18 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-17 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 Document update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-17 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 Can we and should we add an apply function in trait Message's companion object which returns a `DefaultMessage`? --- If your project is set up for it, you can reply to this email and ha

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-17 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=h1) Report > Merging [#183](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=desc)